Skip to content

refactor: strip all local symbols from macOS and iOS App.framework - reduces app size #111264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 9, 2022
Merged

refactor: strip all local symbols from macOS and iOS App.framework - reduces app size #111264

auto-submit merged 2 commits into from
Sep 9, 2022

Conversation

@vaind
Copy link
Member

@vaind vaind commented Sep 9, 2022 •
edited
Loading

Follow up from #101586 (comment)

Changes striping debug symbols to striping all local symbols for iOS and macOS.

I've also manually checked sizes of App.framework's App lib before and after the change on the integration test apps and the changes yield a nice reduction

strip -S strip -x Difference
iOS 2903776 2638864 -258.7 KiB (9 %)
macOS 18272448 15835152 -2.32 MiB (13 %)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 9, 2022
@vaind vaind mentioned this pull request Sep 9, 2022
Merged
13 tasks
@vaind vaind marked this pull request as ready for review September 9, 2022 14:57
jmagman
jmagman approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the tests.

When this merges I think we'll see the drop in these benchmarks: https://flutter-flutter-perf.skia.org/e/?end=1662485121&queries=sub_result%3Dapp_framework_uncompressed_bytes%26sub_result%3Drelease_size_bytes%26test%3Dhello_world_ios__compile%26test%3Dhello_world_macos__compile&xbaroffset=30168

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 9, 2022

auto label is removed for flutter/flutter, pr: 111264, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 9, 2022

auto label is removed for flutter/flutter, pr: 111264, due to Validations Fail.

christopherfujino
christopherfujino approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaind vaind changed the title refactor: strip all local symbols from macOS and iOS App.framework refactor: strip all local symbols from macOS and iOS App.framework - reduces app size Sep 9, 2022
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2022
@auto-submit auto-submit bot merged commit d63442c into flutter:master Sep 9, 2022
@vaind vaind deleted the refactor/apple-strip-all branch September 10, 2022 10:56
@vaind
Copy link
Member Author

vaind commented Sep 10, 2022

LGTM, thanks for the tests.

When this merges I think we'll see the drop in these benchmarks: https://flutter-flutter-perf.skia.org/e/?end=1662485121&queries=sub_result%3Dapp_framework_uncompressed_bytes%26sub_result%3Drelease_size_bytes%26test%3Dhello_world_ios__compile%26test%3Dhello_world_macos__compile&xbaroffset=30168

There was a drop (after removing the end from the query)
image

not sure why it was staggered though 🤷

This was referenced Sep 10, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
e252f75 
…ework - reduces app size (flutter/flutter#111264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 10, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
62cb7ec 
…ework - reduces app size (flutter/flutter#111264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 10, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
042ac10 
…ework - reduces app size (flutter/flutter#111264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 11, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
5a36444 
…ework - reduces app size (flutter/flutter#111264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
0486e59 
…ework - reduces app size (flutter/flutter#111264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
0163efa 
…ework - reduces app size (flutter/flutter#111264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
97a6e7a 
…ework - reduces app size (flutter/flutter#111264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 13, 2022
@engine-flutter-autoroll
d63442c refactor: strip all local symbols from macOS and iOS App.fram…
a500861 
…ework - reduces app size (flutter/flutter#111264)
@jmagman jmagman mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaind @jmagman @christopherfujino