Migrated Checkbox to Material 3 - Added Error State
#111153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: api docs
QuncCccccc
force-pushed
the
add_support_for_checkbox_error_state
branch
from
cd2bb82 to
9c3af95
Compare
HansMuller
approved these changes
Sep 8, 2022
| // so that they can be lerped between. | ||
| final Set<MaterialState> activeStates = states..add(MaterialState.selected); | ||
| final Set<MaterialState> inactiveStates = states..remove(MaterialState.selected); | ||
| final Set<MaterialState> errorState = states..add(MaterialState.error); |
Contributor
There was a problem hiding this comment.
This is confusing to read because states refers to a getter that constructs a new set rather than a local variable or a field. The code appears to be side-effecting the same set of states in each statement, rather than implicitly generating a new one each time that states appears in an expression. No need to fix this now, however if we refactor this code in the future...
| setState(() { | ||
| isChecked = value; | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
trailing commas can be added here and elsewhere
bleroux
reviewed
Sep 8, 2022
| expect(focusNode.hasPrimaryFocus, isFalse); | ||
| expect( | ||
| Material.of(tester.element(find.byType(Checkbox))), | ||
| paints..path(color: theme.colorScheme.error)..path(color: theme.colorScheme.onError) |
This was referenced Sep 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added an error state for the Checkbox. Fixes #104446
In order to use the Checkbox with the new Material 3 defaults, turn on the useMaterial3 flag in the ThemeData:
This PR adds a new property
isErrorforCheckbox. To show a checkbox in an error state, setisErrorto true.Pre-launch Checklist
///).