Update null safety warnings in prep for Dart 3 #110998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
Member
Author
|
|
9 tasks
| } else { | ||
| globals.printStatus( | ||
| 'Building without sound null safety', | ||
| 'Building without sound null safety ⚠️', |
Contributor
There was a problem hiding this comment.
You'll need to add this emoji to https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/base/logger.dart#L717-L726
So that we don't try to print it on old windows terminals
christopherfujino
approved these changes
Sep 6, 2022
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM with Jonah's nit
This was referenced Sep 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 7, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
In Dart 3 only sound null safety will be allowed. This PR updates the output of
flutter runandflutter buildto provide a warning about this ahead of time. The messages link to the dart.dev nulls safety page, which is being updated to state this in dart-lang/site-www#4211.List which issues are fixed by this PR. You must list at least one issue.
Contributes to dart-lang/sdk#49530, fixes #111116
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.