Skip to content

Vertical overflow warning for single-line text fields, InputDecorator prioritizes child over contentPadding when there's not enough vertical space. #110966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LongCatIsLooong wants to merge 13 commits into from
Closed

Vertical overflow warning for single-line text fields, InputDecorator prioritizes child over contentPadding when there's not enough vertical space. #110966

LongCatIsLooong wants to merge 13 commits into from

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 5, 2022 •
edited
Loading

This is known to be a breaking change. I'm working on a migration guide.

Fixes #35706

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 5, 2022
@LongCatIsLooong LongCatIsLooong force-pushed the render-editable-overflow branch from 0df3b1a to 1f8ac32 Compare September 6, 2022 01:56
@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Sep 6, 2022

Many of the failures here and in g3 are caused by the default content padding in InputDecoration.

@LongCatIsLooong LongCatIsLooong force-pushed the render-editable-overflow branch from 1f8ac32 to 5ba85be Compare September 6, 2022 05:48
@LongCatIsLooong LongCatIsLooong mentioned this pull request Sep 15, 2022
Closed
@LongCatIsLooong LongCatIsLooong mentioned this pull request Sep 20, 2022
Merged
8 tasks
@LongCatIsLooong LongCatIsLooong mentioned this pull request Sep 21, 2022
Merged
8 tasks
@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Jan 23, 2023

The website is frozen: I'll create a migration guide for the breaking changes afterwards.

@LongCatIsLooong LongCatIsLooong force-pushed the render-editable-overflow branch from e96446e to 2b91ecb Compare February 3, 2023 20:14
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review February 3, 2023 21:21
@LongCatIsLooong LongCatIsLooong changed the title Single-line RenderEditable overflow warning InputDecorator prioritize child over contentPadding when there's not enough vertical space. Feb 3, 2023
@LongCatIsLooong LongCatIsLooong changed the title InputDecorator prioritize child over contentPadding when there's not enough vertical space. InputDecorator prioritizes child over contentPadding when there's not enough vertical space. Feb 3, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 3, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #110966 at sha c05fc79

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 3, 2023
@LongCatIsLooong LongCatIsLooong changed the title InputDecorator prioritizes child over contentPadding when there's not enough vertical space. Vertical overflow warning for single-line text fields, InputDecorator prioritizes child over contentPadding when there's not enough vertical space. Feb 3, 2023
@LongCatIsLooong LongCatIsLooong marked this pull request as draft February 8, 2023 19:06
@gnprice
Copy link
Member

gnprice commented Feb 22, 2023

Fixes #35706

It looks like that issue is marked as closed already. Should it be reopened?

@gnprice gnprice mentioned this pull request Feb 22, 2023
Closed
@Hixie Hixie marked this pull request as ready for review May 2, 2023 22:54
@gnprice gnprice mentioned this pull request Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextField should warn on vertical overflow

2 participants

@LongCatIsLooong @gnprice