Skip to content

Use raw fontFamilyFallback values without packages when constructing a merged TextStyle #110887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 7, 2022
Merged

Use raw fontFamilyFallback values without packages when constructing a merged TextStyle #110887

auto-submit merged 1 commit into from
Sep 7, 2022

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Sep 2, 2022

Fixes #110843

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Sep 2, 2022
goderbauer
goderbauer approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2022
@auto-submit auto-submit bot merged commit dcf42ad into flutter:master Sep 7, 2022
This was referenced Sep 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
dcf42ad Use raw fontFamilyFallback values without packages when const…
5d08eee 
…ructing a merged TextStyle (flutter/flutter#110887)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
dcf42ad Use raw fontFamilyFallback values without packages when const…
b108e2f 
…ructing a merged TextStyle (flutter/flutter#110887)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
dcf42ad Use raw fontFamilyFallback values without packages when const…
bb6eeb9 
…ructing a merged TextStyle (flutter/flutter#110887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fontFamilyFallback incorrect after TextStyle merge

2 participants

@jason-simmons @goderbauer