Skip to content

Use semantics label for backbutton and closebutton for Android #110873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Sep 2, 2022
Merged

Use semantics label for backbutton and closebutton for Android #110873

auto-submit merged 4 commits into from
Sep 2, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Sep 2, 2022 •
edited
Loading

fixes #110790

This PR matches how native backbutton sets up its semantics node.

If the label and tooltip are the same, talkback will pronounce <Label>, button and skips the tooltip. so that the same string will not be announce twice. This also matches the native implementation.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 2, 2022
@chunhtai chunhtai marked this pull request as ready for review September 2, 2022 22:44
jonahwilliams
jonahwilliams approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2022
@auto-submit auto-submit bot merged commit 22c8e79 into flutter:master Sep 2, 2022
This was referenced Sep 3, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
4ea3eed 
flutter/flutter#110873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
64beb25 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
c987344 
flutter/flutter#110873)
This was referenced Sep 4, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
ab3c60d 
flutter/flutter#110873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
46780d6 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
174d36d 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
db1c831 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
8d854dd 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
bce70a1 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
1161a80 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
846e005 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
35bed2a 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
962241f 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
f1bd84d 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
180e2a8 
flutter/flutter#110873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
91266ec 
flutter/flutter#110873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
22c8e79 Use semantics label for backbutton and closebutton for Android (
49fb755 
flutter/flutter#110873)
XilaiZhang added a commit that referenced this pull request Sep 9, 2022
@XilaiZhang
Revert "Use semantics label for backbutton and closebutton for Android (
4aef1f5 
#110873)"

This reverts commit 22c8e79.
@XilaiZhang XilaiZhang mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[A11y] BackButton and CloseButton should have appropriate labels.

2 participants

@chunhtai @jonahwilliams