Skip to content

Cupertino picker tap #110733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kavantix wants to merge 5 commits into from
Closed

Cupertino picker tap #110733

Kavantix wants to merge 5 commits into from

Conversation

@Kavantix
Copy link
Contributor

@Kavantix Kavantix commented Aug 31, 2022 •
edited
Loading

Adds support for tapping on items in a cupertino picker
To do so I simply implemented hit testing for the ListWheelScrollView and added a gesture recogniser around all the children.

Drag gestures in the date_picker tests are failing because they need to be converted to custom gestures (the drag is not triggered because of the DragStartBehaviour.start).
I can convert those but would first like some feedback on the approach before sinking in that time.

Fixes #38803
Fixes #24089

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Aug 31, 2022
@Kavantix Kavantix marked this pull request as draft August 31, 2022 23:48
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 31, 2022

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@MitchellGoodwin
Copy link
Contributor

MitchellGoodwin commented Sep 28, 2022

Thank you for your contribution. Are you still working on this? Feel free to reach out on Discord if you need help finishing this.

@bdlukaa
Copy link

bdlukaa commented Oct 12, 2022

This fix would enable us to close bdlukaa/fluent_ui#6. Looking foward to it! Thanks :)

@MitchellGoodwin
Copy link
Contributor

MitchellGoodwin commented Jan 3, 2023

Thank you for your contribution! I'm going to close this PR for now to unblock the queue, but feel free to reopen if you want to continue working on this.

@victorsanni
Copy link
Contributor

victorsanni commented Aug 13, 2024 •
edited
Loading

Hi @Kavantix! Can I pick up where you left off with respect to this PR if you're no longer working on it? With the work you've done here, as well as the changes in #121342, it should be trivial to complete.

@Kavantix
Copy link
Contributor Author

Kavantix commented Aug 13, 2024

@victorsanni feel free!

@victorsanni victorsanni mentioned this pull request Aug 13, 2024
Merged
9 tasks
auto-submit bot pushed a commit that referenced this pull request Aug 20, 2024
@victorsanni
Implement tap to scroll to item in CupertinoPicker (#153386)
c631ad9 
Finishes the work started by @Kavantix in #110733.

Fixes #24089.

Before:

https://github.com/user-attachments/assets/7ca0d346-7538-44a0-b0b2-41cf96eee6eb

After:

https://github.com/user-attachments/assets/8da91188-28a0-4738-a216-e03946f00284

Native picker:

https://github.com/user-attachments/assets/8662b3c0-0443-4f8d-818b-cabd97d37de8
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@victorsanni @Buchimi
Implement tap to scroll to item in CupertinoPicker (flutter#153386)
40d6121 
Finishes the work started by @Kavantix in flutter#110733.

Fixes flutter#24089.

Before:

https://github.com/user-attachments/assets/7ca0d346-7538-44a0-b0b2-41cf96eee6eb

After:

https://github.com/user-attachments/assets/8da91188-28a0-4738-a216-e03946f00284

Native picker:

https://github.com/user-attachments/assets/8662b3c0-0443-4f8d-818b-cabd97d37de8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListWheelScrollView children do not respond on gesture (onTap) events Tapping items is not working in CupertinoPicker

4 participants

@Kavantix @MitchellGoodwin @bdlukaa @victorsanni