Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@0ef08a8...300592b

2022-08-30 [email protected] allows mallocmapping copies of size zero (flutter/engine#35803)
2022-08-30 [email protected] [web] roll CanvasKit to 0.36.1 (flutter/engine#35747)

Also rolling transitive DEPS:
flutter/web/canvaskit_bundle from yrsfF-vTvu4j to 8wh6J7ZXGCgo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2022
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #110609 at sha 6ad4e97

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Aug 30, 2022
@zanderso
Copy link
Member

@yjbanov Are the skia diffs expected from the CanvasKit roll?

@zanderso
Copy link
Member

Closing to trigger a new roll.

@zanderso zanderso closed this Aug 31, 2022
@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-564f6293-a004-4047-803a-73c3eeb19be4-1661887454 branch September 6, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants