Skip to content

Make module tests pass on Xcode 14 #110556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 30, 2022
Merged

Make module tests pass on Xcode 14 #110556

auto-submit merged 2 commits into from
Aug 30, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 30, 2022 •
edited
Loading

Remove arm64_armv7 directories and bitcode checks for built/embedded frameworks. Leave the bitcode checks for Flutter.framework and App.framework, to be removed later as part of #107887.

Tested locally on Xcode 14 beta 5.

Fixes #110555
Fixes #110553
Reverts the unnecessary armv7 checks from #101592 post-#97327.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Aug 30, 2022
@jmagman jmagman self-assigned this Aug 30, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 30, 2022
jmagman
jmagman commented Aug 30, 2022
View reviewed changes
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
checkFileExists(simulatorFrameworkHeaderPath);
}

checkDirectoryExists(path.join(
Copy link
Member Author

@jmagman jmagman Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BCSymbolMaps is a bitcode thing, and is no longer generated in Xcode 14.

@jmagman jmagman mentioned this pull request Aug 30, 2022
Closed
10 tasks
cyanglaz
cyanglaz approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2022
@auto-submit auto-submit bot merged commit a4530b7 into flutter:master Aug 30, 2022
@jmagman jmagman deleted the module-tests branch August 30, 2022 18:52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
a4530b7 Make module tests pass on Xcode 14 (flutter/flutter#110556)
4c5f941
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2022
@engine-flutter-autoroll
a4530b7 Make module tests pass on Xcode 14 (flutter/flutter#110556)
07997b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

module_test_ios fails on Xcode 14 build_ios_framework_module_test fails on Xcode 14

2 participants

@jmagman @cyanglaz