[flutter_tools] Pull more arm64 artifacts on Apple Silicon #110291
Conversation
flutter-dashboard
bot
added
platform-ios
zanderso
force-pushed
the
more-arm64-artifacts
branch
2 times, most recently
from
8be0993 to
9dffb3e
Compare
zanderso
force-pushed
the
more-arm64-artifacts
branch
from
9dffb3e to
47b0360
Compare
There was a problem hiding this comment.
I don't see anywhere we're testing flutter test on an arm Mac in CI.
flutter_test_performance only runs on Linux.
framework_tests shard runs on x64:
Line 773 in 6e57ed6
misc shard runs example smoke tests runs on x64:
Line 961 in 6e57ed6
I actually just got misc passing on arm, that might be a good one to run in both archs. Updated go/flutter-mac-test-architectures.
https://github.com/flutter/flutter/pull/109889/checks?check_run_id=8028285978
Trying framework_tests_misc on this PR on arm:
https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/magder_google.com/558f51ea68106e71f9af03e428a133229f451fe8e57879aa6b0741c85f1864d1/+/build.proto
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
This also fixes #106763.
The led run passed:
https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/magder_google.com/558f51ea68106e71f9af03e428a133229f451fe8e57879aa6b0741c85f1864d1/+/build.proto passed:
darwin-arm64 downloaded:
> GET /flutter_infra_release/flutter/90d1a67e0d8b76bf769d16aae9e6563f07cace73/dart-sdk-darwin-arm64.zip HTTP/2
Downloading darwin-arm64 tools... 692ms
...
Downloading darwin-arm64/font-subset tools... 116ms
flutter tests passed, presumably running natively:
https://logs.chromium.org/logs/flutter/led/magder_google.com/558f51ea68106e71f9af03e428a133229f451fe8e57879aa6b0741c85f1864d1/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/test_stdout
LGTM
|
Here's one that exercises impeller: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/magder_google.com/350dfe0bd08ece80558fdef608b717c295746e04201fcbaa0335bed1ea50a4c3/+/build.proto |
|
Hi On what version of flutter will this be released? 👍🏻 |
|
This is available on 3.4.0-18.0.pre. |
3 participants
If the host is an arm64 mac, this PR causes arm64 tools to be downloaded instead of x64 tools. To avoid a large refactoring to the artifact cache, the arm64 tools are still placed in the
darwin-x64directory. Luckily the name of the directory isn't too important. We might even consider just renaming itdarwininstead of trying to plumb host architecture information all over the place.Fixes: #110227 #110226 #109892