Skip to content

Deprecate ThemeData errorColor and backgroundColor #110162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 19 commits into from
Sep 2, 2022
Merged

Deprecate ThemeData errorColor and backgroundColor #110162

auto-submit merged 19 commits into from
Sep 2, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Aug 24, 2022

In line with https://flutter.dev/go/material-theme-system-updates and #91772, deprecates redundant ThemeData properties.

Old New Previous usages
ThemeData.errorColor ColorScheme.error TextField error states
ThemeData.backgroundColor ColorScheme.background was unused

A Dart fix is provided.

This is not a breaking change, per our policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl guidezpl requested a review from Piinks August 24, 2022 09:26
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Aug 24, 2022
@guidezpl guidezpl changed the title Deprecate error and background Deprecate ThemeData errorColor and backgroundColor Aug 24, 2022
This was referenced Aug 24, 2022
Closed
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
1c9f731 
…tter/flutter#110162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
d7a52ea 
…tter/flutter#110162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
ce97ee0 
…tter/flutter#110162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
3180a3b 
…tter/flutter#110162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
0364ff3 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
1d8ce7f 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
8342043 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
3e2eba7 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
61d8ba9 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
342bb76 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
6942dbf 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
de996c2 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
b7f788c 
…tter/flutter#110162)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
8853926 Deprecate ThemeData errorColor and backgroundColor (flu…
f7f6376 
…tter/flutter#110162)
@XilaiZhang XilaiZhang mentioned this pull request Sep 8, 2022
Closed
@guidezpl guidezpl restored the deprecate-error-and-background branch September 9, 2022 10:03
@guidezpl guidezpl deleted the deprecate-error-and-background branch September 9, 2022 10:06
@guidezpl guidezpl mentioned this pull request Sep 14, 2022
Closed
8 tasks
@DanTup DanTup mentioned this pull request Sep 25, 2023
Closed
This was referenced Feb 24, 2024
Merged
Merged
Merged
auto-submit bot pushed a commit that referenced this pull request Feb 28, 2024
@QuncCccccc
Remove bottomAppBarColor from ThemeData (#144080)
e707f0d 
This PR is to remove deprecated ThemeData.bottomAppBarColor.

These parameters are made obsolete in #110162.
Part of #111080
auto-submit bot pushed a commit that referenced this pull request Feb 29, 2024
@QuncCccccc
Remove deprecated backgroundColor from ThemeData (#144079)
ee6111a 
This PR is to remove deprecated ThemeData.backgroundColor.

These parameters are made obsolete in #110162.
Part of #143956
auto-submit bot pushed a commit that referenced this pull request Mar 6, 2024
@QuncCccccc
Remove deprecated errorColor from ThemeData (#144078)
f38c5ad 
This PR is to remove deprecated `ThemeData.errorColor`.

These parameters are made obsolete in #110162.
Part of #143956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannah-hyj hannah-hyj hannah-hyj approved these changes

@Piinks Piinks Awaiting requested review from Piinks

@QuncCccccc QuncCccccc Awaiting requested review from QuncCccccc

+1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guidezpl @darrenaustin @hannah-hyj