[Windows] Add app startup integration test #110114

loic-sharma · 2022-08-23T20:48:33Z

Add a basic integration test for the Windows's app startup. In a subsequent change (#109816), this test will be updated to verify the app's window isn't visible until after the first frame has been drawn.

Commits:

49f54e0 - Run flutter create. No need to review this!
2ee770e - Prepare new project for changes
49f54e0 - Add app startup integration test

Part of #41980

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dev/integration_tests/windows_startup_test/test_driver/main_test.dart

yaakovschectman

LGTM code-wise other than failing tests, possibly all due to the one newline.

loic-sharma · 2022-08-23T23:28:56Z

dev/devicelab/bin/tasks/windows_startup_test.dart

+
+Future<void> main() async {
+  deviceOperatingSystem = DeviceOperatingSystem.windows;
+  await task(createWindowsStartupDriverTest(deviceIdOverride: 'windows'));


Please let me know if this deviceIdOverride is unnecessary

.ci.yaml

dev/integration_tests/windows_startup_test/windows/flutter/generated_plugin_registrant.cc

dev/integration_tests/windows_startup_test/windows/flutter/generated_plugins.cmake

dev/integration_tests/windows_startup_test/lib/main.dart

cbracken · 2022-08-25T23:44:20Z

dev/integration_tests/windows_startup_test/lib/main.dart

+        MethodChannel('tests.flutter.dev/windows_startup_test');
+
+    final bool? visible = await methodChannel.invokeMethod('isWindowVisible');
+    if (visible == null || visible == false) {


Shouldn't the window not be visible at startup (until beginFirstFrame)?

(Sorry forgot to reply to this comment!)

Hiding the app's window until after the first frame was moved into its own pull request: #109816

cbracken

…10114)

loic-sharma added 3 commits August 23, 2022 13:22

Add new windows_startup_test project

e907613

Clean project

2ee770e

[Windows] Add app startup integration test

49f54e0

loic-sharma requested a review from keyonghan as a code owner August 23, 2022 20:48

flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 23, 2022

loic-sharma requested review from a-wallen, cbracken, gspencergoog and yaakovschectman August 23, 2022 20:57

yaakovschectman reviewed Aug 23, 2022

View reviewed changes

dev/integration_tests/windows_startup_test/test_driver/main_test.dart Outdated Show resolved Hide resolved

yaakovschectman approved these changes Aug 23, 2022

View reviewed changes

Add missing new line

312be92

loic-sharma commented Aug 23, 2022

View reviewed changes

a-wallen reviewed Aug 24, 2022

View reviewed changes

.ci.yaml Show resolved Hide resolved

a-wallen approved these changes Aug 24, 2022

View reviewed changes

Merge branch 'master' into windows_startup_test

7154708