Skip to content

[macOS] Bring up "complex_layout" devicelab, compilation test for x86 and arm64 #110090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-wallen merged 0 commits into from
Aug 24, 2022
Merged

[macOS] Bring up "complex_layout" devicelab, compilation test for x86 and arm64 #110090

a-wallen merged 0 commits into from
Aug 24, 2022

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Aug 23, 2022

From #109633

The initial desktop integration tests are running now, but they need to be expanded beyond the initial gallery build test; filing this to make sure that planned work is captured in the issue tracker. This should be much more straightforward that getting the first one running was, since the bot work is all complete.

In particular we should ensure we are testing building a freshly created project to catch errors in template changes. (I haven't checked where that test lives on existing platforms; it may be a device lab test, which still needs desktop bring-up).

Fixes #110081

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 23, 2022
@a-wallen a-wallen force-pushed the macos_bringup_complex_compile branch from fe1a661 to 63c915e Compare August 23, 2022 16:43
christopherfujino
christopherfujino reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had some style nits here; however, you should probably wait for our 1:1 before fixing any of these, as we can discuss high level strategy.

dev/devicelab/lib/tasks/perf_tests.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to flush here? also, why unawaited?

dev/devicelab/lib/tasks/perf_tests.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can actually be final because of definite assignment analysis https://dart.dev/null-safety/understanding-null-safety#definite-assignment-analysis

dev/devicelab/lib/framework/devices.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extension methods are against Flutter's style guide https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-extension

And I believe you can achieve the same effect now with Dart's new enhanced enum's: https://dart.dev/guides/language/language-tour#enumerated-types https://medium.com/dartlang/dart-2-17-b216bfc80c5d

@a-wallen a-wallen force-pushed the macos_bringup_complex_compile branch from 63c915e to cdd1895 Compare August 24, 2022 18:13
@a-wallen a-wallen merged commit 2966884 into flutter:master Aug 24, 2022
@a-wallen a-wallen force-pushed the macos_bringup_complex_compile branch from cdd1895 to 2966884 Compare August 24, 2022 19:02
This was referenced Aug 25, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[macOS] Bring up "complex_layout" devicelab, compilation test for x86.

2 participants

@a-wallen @christopherfujino