Skip to content

Conversation

@keyonghan
Copy link
Contributor

fixed: #104034

@jmagman
Copy link
Member

jmagman commented Aug 23, 2022

We don't need to address in this PR, but something to think about: mac and mac_arm could be used for macOS desktop benchmarks, so do we need to peg to a particular Mac model like Macmini8,1 or Macmini9,1 so they all run on the same type of machine?

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this, can you add a presubmit Mac_arm64 tool_host_cross_arch_tests? The intention of that shard was to test tool behavior that's different between architectures.

flutter/.ci.yaml

Line 2705 in 129fa76

- name: Mac tool_host_cross_arch_tests

@keyonghan
Copy link
Contributor Author

To test this, can you add a presubmit Mac_arm64 tool_host_cross_arch_tests? The intention of that shard was to test tool behavior that's different between architectures.

flutter/.ci.yaml

Line 2705 in 129fa76

- name: Mac tool_host_cross_arch_tests

Added.

@keyonghan
Copy link
Contributor Author

We don't need to address in this PR, but something to think about: mac and mac_arm could be used for macOS desktop benchmarks, so do we need to peg to a particular Mac model like Macmini8,1 or Macmini8,1 so they all run on the same type of machine?

Seems we deprecated the mac model in: #101871.
From the bot pool side, Macmini8,1 is equal to cpu: x64 whereas Macmini9,1 is equal to cpu: arm64. Do we expect to have more different configs?

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Mac_arm64 tool_host_cross_arch_tests passes, what's the difference between this and what I did in #109889, which failed that shard because arm64 Ruby wasn't installed?

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_host_cross_arch_tests/3779/overview

@jmagman
Copy link
Member

jmagman commented Aug 23, 2022

Do we expect to have more different configs?

I'm not sure, will the new arm macs also be Macmini9,1?

Copy link
Contributor

@a-wallen a-wallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan
Copy link
Contributor Author

If Mac_arm64 tool_host_cross_arch_tests passes, what's the difference between this and what I did in #109889, which failed that shard because arm64 Ruby wasn't installed?

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_host_cross_arch_tests/3779/overview

The new target is not picked up by this PR, as it's a new target as bringup: true. These targets are not expected to run in pre-submit. Manually ran an led build, and it failed as well.
Closing this as in favor of #109889.

@keyonghan keyonghan closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support mac_arm64 host only test configuration

3 participants