-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add mac_arm64 host only platform support in .ci.yaml #110050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We don't need to address in this PR, but something to think about: |
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test this, can you add a presubmit Mac_arm64 tool_host_cross_arch_tests? The intention of that shard was to test tool behavior that's different between architectures.
Line 2705 in 129fa76
| - name: Mac tool_host_cross_arch_tests |
Added. |
Seems we deprecated the mac model in: #101871. |
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Mac_arm64 tool_host_cross_arch_tests passes, what's the difference between this and what I did in #109889, which failed that shard because arm64 Ruby wasn't installed?
I'm not sure, will the new arm macs also be |
a-wallen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The new target is not picked up by this PR, as it's a new target as |
fixed: #104034