Re-enable coverage and docs uploading #10995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So the theory here is that we will always download the Cloud SDK, even if we don't need it, so that we can notice this kind of problem sooner? |
Contributor
Author
|
Naah the theory was that I wanted to see if the problem was resolved (since the DL SRE said they couldn't see any issues on their side) in my PR before I merged. If they were, then I'd update it to only run on non-PRs and merge it. Though there certainly is an argument to be made for doing this always so we see it earlier... |
Contributor
Author
|
Given that the download shouldn't take long, I did remove the PR restriction so we'll catch download errors earlier. |
Contributor
|
|
Hixie
added a commit
that referenced
this pull request
Jun 27, 2017
Contributor
|
That's really weird. It worked fine in the PR, but failed on master. |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10940