-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Run Mac hostonly tests on any available arch #109889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@keyonghan what else needs to be done to make sure the arm64 cipd packages are used on arm bots, and Rosetta is installed? Ideally this behavior is tied to the cpu property of the bot and not the name of the task/builder so that it can run on any bot with any architecture, given available capacity. |
|
For Rosetta, filed https://bugs.chromium.org/p/chromium/issues/detail?id=1354817 |
This one failed missing |
#110110 to fix. |
Filed #110113 |
|
@keyonghan everything passed when I added the |
Wait, that tag didn't even get applied? I guess the tags on the individual tasks override it, not add to it? |
|
Hm the passing tests actually ran on x86 even though they had the |
The tag is used only for data analysis purpose, and it should not affect platform selection. |
|
Blocked on getting Rosetta on these machines https://bugs.chromium.org/p/chromium/issues/detail?id=1354817 |
This happened again... |
|
Filed #110561 to install arm Ruby on arm bots. |
Allow Mac hostonly (not devicelab or benchmark) tests to run on any available architecture, not just x64 Intel machines.
Example expands available bots for this category of tests from
https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=cpu&c=os&c=status&d=asc&f=pool%3Aluci.flutter.prod&f=os%3AMac-12&f=cpu%3Ax86&f=device_type%3Anone&s=id
to
https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=cpu&c=os&c=status&d=asc&f=pool%3Aluci.flutter.prod&f=os%3AMac-12&f=device_type%3Anone&s=id
Also run
tool_host_cross_arch_testson both archs, as that's the intention of that shard.Remove
arm64rubydependency, unnecessary as of #110561.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.