Use defaultTargetPlatform instead of Platform.operatingSystem for ImageProvider. #10986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geProvider. Add convenience helper to make it easier to display a short string for an enums value.
Hixie
reviewed
Jun 27, 2017
| /// assert(describeEnum(Day.monday) == 'monday'); | ||
| /// } | ||
| /// ``` | ||
| String describeEnum(Object enumEntry) { |
Contributor
There was a problem hiding this comment.
maybe link to the dart bug in a comment (not dartdoc comment)
Contributor
|
|
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
…geProvider. (flutter#10986) * Use defaultTargetPlatform instead of Platform.operatingSystem for ImageProvider. Add convenience helper to make it easier to display a short string for an enums value. * Add comment linking to issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a convenience helper to make it easier to display a short string for enum values.