Avoid null terminating characters in strings from Utf8FromUtf16() #109729

tgucio · 2022-08-17T22:45:28Z

This PR adds passing source wchar_t* string length to WideCharToMultiByte() in Utf8FromUtf16() in order to avoid including the terminating null character in the resulting string. This was found when the Utf8FromUtf16() function in the generated utils.cpp file was used for another purpose (a platform specific extension using method channel).

From https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-widechartomultibyte:

[in] cchWideChar
Size, in characters, of the string indicated by lpWideCharStr. Alternatively, this parameter can be set to -1 if the string is null-terminated. If cchWideChar is set to 0, the function fails.
If this parameter is -1, the function processes the entire input string, including the terminating null character. Therefore, the resulting character string has a terminating null character, and the length returned by the function includes this character.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

flutter-dashboard · 2022-08-17T22:45:32Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

tgucio · 2022-08-17T22:47:30Z

/cc @cbracken

packages/flutter_tools/templates/app_shared/windows.tmpl/runner/utils.cpp

cbracken

I'm a bit concerned by this change in that it changes the semantics of these functions in a potentially breaking way for callers. I believe that in every use we have of these functions in the templates, we're assuming copying of the full string.

There are cases where we ask users to regenerate the app project using flutter create (e.g. migrations) and changing the behaviour of these could break existing uses they have in their projects.

Can you provide a bit more motivation for this change?

tgucio · 2022-08-18T21:09:48Z

@cbracken to me the behaviour of adding the null terminating char to the resulting C++ std::string isn't intended.
Here's how I stumbled upon this: I recycled the Utf8FromUtf16() function in order to pass wchar_t* file path from DragQueryFile() to channel_->InvokeMethod() via flutter::EncodableMap(). To my amazement I found the paths in Dart had an extra character that couldn't be removed with trim() because it was a null character (which happens to be a valid UTF-8 code point).

christopherfujino · 2022-09-08T20:34:28Z

@cbracken or @loic-sharma do either of you have time to take another look at this one?

christopherfujino · 2022-09-14T21:46:48Z

@cbracken or @loic-sharma do either of you have time to take another look at this one?

pinged on discord

Jasguerrero · 2022-09-22T20:15:05Z

Discussion happening on discord chat

cbracken

lgtm for the fix. This is testable but we don't currently have a mechanism for testing template bugs. I'm going to play around with a means of doing so.

cbracken

Just to be clear - please do not land this until we have a test in place. (I'm taking a look at doing so right now)

cbracken

Alright after hacking in a manual test, this fix also failed but in a different way, instead we get ERROR_INSUFFICIENT_BUFFER. I do have a patched version of the fix that works -- passing in the input buffer size rather than letting WideCharToMultiByte compute it results in a pass and avoids the manual target_length adjustment.

I'll put together a patch that adds a mechanism to test this.

gspencergoog · 2022-09-29T18:15:36Z

Converting back to a draft PR until there are tests. (Desktop triage)

cbracken · 2023-01-26T19:14:58Z

@yaakovschectman has added infrastructure for testing template code. The tests for this code are in #118647. Apologies for the delay on getting infra in place on our end. Do you have time to add a test? (Desktop triage)

tgucio · 2023-01-27T18:55:06Z

@cbracken Sure, I'll take a look at testing this. I'm guessing we'd only need a test in dev/integration_tests/windows_startup_test/test_driver/main_test.dart as #118646 takes care of ensuring the utils.cpp matches the current app template.

loic-sharma · 2023-01-30T18:42:19Z

@tgucio Yup that's right. I would update the test here: https://github.com/flutter/flutter/pull/118647/files#diff-9e45c9708d35a2474dcea00dc2aa3d74afcc6e7ecc832e062b9b470a990280d0R49-R58

yaakovschectman · 2023-01-30T19:41:37Z

Because you modify packages/flutter_tools/templates/app_shared/windows.tmpl/runner/utils.cpp, you will need to propagate the change to all tests that use that template file so that the file is up-to-date. In this case this means you will need to modify sdk/dev/integration_tests/windows_startup_test/windows/runner/utils.cpp and sdk/dev/integration_tests/ui/windows/runner/utils.cpp. I think you will also need to update the test linked in the above comment to account for the now-missing null codepoint.

…16() (flutter/flutter#109729)

…tf16() (flutter/flutter#109729)

…16() (flutter/flutter#109729)

…tf16() (flutter/flutter#109729)

…16() (flutter/flutter#109729)

…tf16() (flutter/flutter#109729)

…16() (flutter/flutter#109729)

…tf16() (flutter/flutter#109729)

…16() (flutter/flutter#109729)

* 7fb8497 Roll Plugins from 02571ec0dd36 to f3bc6f1eb0c2 (2 revisions) (flutter/flutter#120601) * 7c2d5b9 60c8532d6 Roll Fuchsia Mac SDK from NZAnfCkpbswhYplty... to 6hbPQq6ED0PkuQiKM... (flutter/engine#39587) (flutter/flutter#120602) * 1f268f1 fb8840578 Roll Dart SDK from 1caf3a9ad101 to f80c5db8736a (1 revision) (flutter/engine#39588) (flutter/flutter#120606) * 957494d Marks Linux_android flavors_test to be unflaky (flutter/flutter#120299) * 0792c27 Roll Flutter Engine from fb8840578156 to df0ffe42b33e (2 revisions) (flutter/flutter#120607) * 7bacc25 Remove accentColorBrightness usage (flutter/flutter#120577) * 98576ce Avoid null terminating characters in strings from Utf8FromUtf16() (flutter/flutter#109729) * 00adf9a roll packages (flutter/flutter#120609) * 2df140f Remove references to Observatory (flutter/flutter#118577) * a819d61 Remove `prefer_equal_for_default_values` lint rule (flutter/flutter#120533) * 73afc7b Roll Flutter Engine from df0ffe42b33e to 97dcf3e6201e (4 revisions) (flutter/flutter#120617) * f858302 Remove `brightness` from `AppBar`/`SliverAppBar`/`AppBarTheme`/`AppBarTheme.copyWith` (flutter/flutter#120575) * 95fd821 Force `Mac build_tests` to run on x64 bots (flutter/flutter#120620) * ed35c80 d28cbf402 [Impeller] Return entity from filters instead of a snapshot (flutter/engine#39560) (flutter/flutter#120625) * 778b3fa support updating dragDecices at runtime (flutter/flutter#120336) * ddebe83 Added integration test for wide gamut support. (flutter/flutter#119657) * becb6bd Fix message type inconsistency between locales (flutter/flutter#120129) * f4495f5 Roll Flutter Engine from d28cbf402904 to 31a4648cbe99 (2 revisions) (flutter/flutter#120630) * 402caec Fix `ListTile`'s default `iconColor` token used & update examples (flutter/flutter#120444) * 865422d Force `Mac tool_integration_tests` to run on x64 bots (flutter/flutter#120634) * 07c548c Apply BindingBase.checkInstance to TestDefaultBinaryMessengerBinding (flutter/flutter#116937) * b08cc8b Roll Flutter Engine from 31a4648cbe99 to c4f51bc78644 (7 revisions) (flutter/flutter#120656) * 6a94f25 Roll Flutter Engine from c4f51bc78644 to 17ab09d382e3 (5 revisions) (flutter/flutter#120664) * b0edf58 Roll Flutter Engine from 17ab09d382e3 to cbb7fc020b00 (2 revisions) (flutter/flutter#120673) * 17b4c70 [M3] Add customizable overflow property to Snackbar's action (flutter/flutter#120394) * b35e4a5 Roll Plugins from f3bc6f1eb0c2 to 9c312d4d2f5f (2 revisions) (flutter/flutter#120694) * 9fd3404 f4fcb911b Roll Skia from bb7b22f3f444 to 8de7f68a3661 (1 revision) (flutter/engine#39619) (flutter/flutter#120699) * b9b4d3e roll packages (flutter/flutter#120628) * ed5bd17 Fix tree by updating dependencies (flutter/flutter#120707) * 480c54c Increase Linux docs_publish timeout (flutter/flutter#120718) * c102bf4 [integration_test] Fix link to integration test for web section in `README.md` (flutter/flutter#103422) * 577ad2e Fix error when resetting configurations in tear down phase (flutter/flutter#114468) * 2cfca82 Force Mac plugin_test to run on x64 bots (flutter/flutter#120714) * fd2fd94 d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to EFcCpAxOuQllDqP0F... (flutter/engine#39621) (flutter/flutter#120702) * 9d94a51 Move linux-x64-flutter-gtk.zip to linux-x64-debug location. (flutter/flutter#120658) * d29668d Improve network resources doctor check (flutter/flutter#120417) * 378668d added MaterialStateColor support to TabBarTheme.labelColor (flutter/flutter#109541) * ba46cb8 Remove deprecated AppBar.color & AppBar.backwardsCompatibility (flutter/flutter#120618) * 5a3957f Revert "Fix error when resetting configurations in tear down phase" (flutter/flutter#120739) * fd01812 Add temporary default case to support new PointerSignalKind (flutter/flutter#120731) * 4b8ad1b Temporarily disable info-based analyzer unit tests. (flutter/flutter#120753) * 911b137 Roll Flutter Engine from d860892528ff to 44e36c9c0d73 (20 revisions) (flutter/flutter#120761) * 4ae5252 Fix license page crash (flutter/flutter#120728) * 31c73fc Roll Flutter Engine from 44e36c9c0d73 to bf7d51586704 (2 revisions) (flutter/flutter#120772) * 624445a Roll Flutter Engine from bf7d51586704 to ec70b5aa96be (2 revisions) (flutter/flutter#120781) * df41e58 1328c4bc6 Roll Dart SDK from 0456c4011cb3 to c022d475e9d8 (1 revision) (flutter/engine#39646) (flutter/flutter#120784)

* 001c495 Roll Flutter Engine from 9a40a384997d to e1d0032029e4 (6 revisions) (flutter/flutter#120414) * 96823590e post submit only (flutter/flutter#120411) * 5dbd28101 Use String.codeUnitAt instead of String.codeUnits[] in ParagraphBoundary (flutter/flutter#120234) * f05a555bc Fix lerping for `NavigationRailThemeData` icon themes (flutter/flutter#120066) * b0d04ea49 add9e11ed Fix position of BackdropFilter above PlatformView (flutter/engine#39244) (flutter/flutter#120415) * 858f94cfa Roll Plugins from 73986f4 to 02571ec (3 revisions) (flutter/flutter#120443) * 298c874ea Fix classes that shouldn't be extended/instantiated/mixedin (flutter/flutter#120409) * 25c2c22d2 Delete Chrome temp cache after closing (flutter/flutter#119062) * b2e37c659 [conductor] Tag engine versions (flutter/flutter#120419) * 780c9a8de Remove deprecated SystemChrome.setEnabledSystemUIOverlays (flutter/flutter#119576) * 52ab29936 Roll Flutter Engine from add9e11edb66 to 4104eb5cbc40 (14 revisions) (flutter/flutter#120470) * 65fd924d8 [conductor] Remove CiYaml model (flutter/flutter#120458) * d5dbcb708 Revert "Revert "[web] Move JS content to its own `.js` files (#117691)" (#120275)" (flutter/flutter#120363) * 2f9abd20f Roll Flutter Engine from 4104eb5cbc40 to 6660300ea34f (6 revisions) (flutter/flutter#120487) * d63c54c9c roll packages (flutter/flutter#120493) * 941578ea9 Roll Flutter Engine from 6660300ea34f to 5e3ff1e5c9b3 (4 revisions) (flutter/flutter#120495) * b3613c4cf f737dc868 [macOS] Add XCode marks for TextInputPlugin (flutter/engine#39550) (flutter/flutter#120501) * 4ab2ffd58 Roll Flutter Engine from f737dc868a3e to 3ac3338489d2 (2 revisions) (flutter/flutter#120505) * 859d57b3c 8baee2164 Roll Skia from 5230650dc096 to 70a3a194ec98 (2 revisions) (flutter/engine#39554) (flutter/flutter#120507) * e42ab1cb0 c3dc68e0e Roll Skia from 70a3a194ec98 to 6c3097e6f833 (1 revision) (flutter/engine#39555) (flutter/flutter#120508) * 61e059f44 Roll Flutter Engine from c3dc68e0e263 to 363355af5158 (2 revisions) (flutter/flutter#120511) * d27de1de0 5efb42971 Roll Fuchsia Linux SDK from 482Njb1v72P7fNyj4... to MVMTNxWJaWdwPWstz... (flutter/engine#39559) (flutter/flutter#120512) * bbf8446d9 761891200 Roll Dart SDK from 1d26a1d57edf to b1836aacc08a (1 revision) (flutter/engine#39561) (flutter/flutter#120513) * 0346f4b18 d8e01097e Roll Fuchsia Mac SDK from 6nMZjuYXTcnD_VZQI... to FxFPRn_9rSWWAWFw0... (flutter/engine#39562) (flutter/flutter#120519) * 0db47bdd0 Revert "Fix BottomAppBar & BottomSheet M3 shadow (#119819)" (flutter/flutter#120492) * f04600bfb Roll Flutter Engine from d8e01097e66b to 2cba062f9f4c (2 revisions) (flutter/flutter#120538) * 274f6cb2d Roll Flutter Engine from 2cba062f9f4c to 05d81c0f2ebe (2 revisions) (flutter/flutter#120547) * d6ff0f2af fe56a45b4 Roll Dart SDK from c4255cea566a to 1caf3a9ad101 (1 revision) (flutter/engine#39571) (flutter/flutter#120552) * 7295d4fe9 9a19d7eea Roll Fuchsia Linux SDK from arbaBzyUE2ok1bGl5... to 8fdyKaKQqTPpjcp-L... (flutter/engine#39572) (flutter/flutter#120554) * 6d68eb7b8 0aa4fcbd2 Roll Skia from ec87ec6fd34f to 615965d545f4 (1 revision) (flutter/engine#39573) (flutter/flutter#120558) * 527977b6a b7e80ad6e Roll Fuchsia Mac SDK from y35kWL0rP5Nd06lTg... to KpTOXssqVhPv2OBZi... (flutter/engine#39574) (flutter/flutter#120559) * 238b0dbc0 Roll Flutter Engine from b7e80ad6ef51 to 1ff345ce5f63 (2 revisions) (flutter/flutter#120574) * 3e659cf71 1eef041d4 [Impeller] Source the pipeline color attachment pixel format from RenderPass textures (flutter/engine#39556) (flutter/flutter#120576) * 53fe8a3f9 4107a7b71 Roll Skia from 615965d545f4 to c6f1de2239fb (1 revision) (flutter/engine#39581) (flutter/flutter#120580) * b0c24e8d3 fix a Slider theme update bug (flutter/flutter#120432) * b33c76f01 1695b7bbc Bump github/codeql-action from 2.1.39 to 2.2.4 (flutter/engine#39584) (flutter/flutter#120588) * ce8efb439 ede2a0a3c Roll Skia from c6f1de2239fb to d85501fa487d (1 revision) (flutter/engine#39585) (flutter/flutter#120593) * 7fb8497b5 Roll Plugins from 02571ec to f3bc6f1 (2 revisions) (flutter/flutter#120601) * 7c2d5b9c2 60c8532d6 Roll Fuchsia Mac SDK from NZAnfCkpbswhYplty... to 6hbPQq6ED0PkuQiKM... (flutter/engine#39587) (flutter/flutter#120602) * 1f268f1d6 fb8840578 Roll Dart SDK from 1caf3a9ad101 to f80c5db8736a (1 revision) (flutter/engine#39588) (flutter/flutter#120606) * 957494d9f Marks Linux_android flavors_test to be unflaky (flutter/flutter#120299) * 0792c2795 Roll Flutter Engine from fb8840578156 to df0ffe42b33e (2 revisions) (flutter/flutter#120607) * 7bacc25ee Remove accentColorBrightness usage (flutter/flutter#120577) * 98576cef5 Avoid null terminating characters in strings from Utf8FromUtf16() (flutter/flutter#109729) * 00adf9a33 roll packages (flutter/flutter#120609) * 2df140f40 Remove references to Observatory (flutter/flutter#118577) * a819d6156 Remove `prefer_equal_for_default_values` lint rule (flutter/flutter#120533) * 73afc7ba3 Roll Flutter Engine from df0ffe42b33e to 97dcf3e6201e (4 revisions) (flutter/flutter#120617) * f858302a6 Remove `brightness` from `AppBar`/`SliverAppBar`/`AppBarTheme`/`AppBarTheme.copyWith` (flutter/flutter#120575) * 95fd821ab Force `Mac build_tests` to run on x64 bots (flutter/flutter#120620) * ed35c80d2 d28cbf402 [Impeller] Return entity from filters instead of a snapshot (flutter/engine#39560) (flutter/flutter#120625) * 778b3fa32 support updating dragDecices at runtime (flutter/flutter#120336) * ddebe833b Added integration test for wide gamut support. (flutter/flutter#119657) * becb6bd00 Fix message type inconsistency between locales (flutter/flutter#120129) * f4495f5d3 Roll Flutter Engine from d28cbf402904 to 31a4648cbe99 (2 revisions) (flutter/flutter#120630) * 402caec2e Fix `ListTile`'s default `iconColor` token used & update examples (flutter/flutter#120444) * 865422da2 Force `Mac tool_integration_tests` to run on x64 bots (flutter/flutter#120634) * 07c548c69 Apply BindingBase.checkInstance to TestDefaultBinaryMessengerBinding (flutter/flutter#116937) * b08cc8be7 Roll Flutter Engine from 31a4648cbe99 to c4f51bc78644 (7 revisions) (flutter/flutter#120656) * 6a94f25a9 Roll Flutter Engine from c4f51bc78644 to 17ab09d382e3 (5 revisions) (flutter/flutter#120664) * b0edf5829 Roll Flutter Engine from 17ab09d382e3 to cbb7fc020b00 (2 revisions) (flutter/flutter#120673) * 17b4c70ff [M3] Add customizable overflow property to Snackbar's action (flutter/flutter#120394) * b35e4a54f Roll Plugins from f3bc6f1 to 9c312d4 (2 revisions) (flutter/flutter#120694) * 9fd34048f f4fcb911b Roll Skia from bb7b22f3f444 to 8de7f68a3661 (1 revision) (flutter/engine#39619) (flutter/flutter#120699) * b9b4d3e43 roll packages (flutter/flutter#120628) * ed5bd1779 Fix tree by updating dependencies (flutter/flutter#120707) * 480c54c37 Increase Linux docs_publish timeout (flutter/flutter#120718) * c102bf467 [integration_test] Fix link to integration test for web section in `README.md` (flutter/flutter#103422) * 577ad2ee8 Fix error when resetting configurations in tear down phase (flutter/flutter#114468) * 2cfca820a Force Mac plugin_test to run on x64 bots (flutter/flutter#120714) * fd2fd94e3 d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to EFcCpAxOuQllDqP0F... (flutter/engine#39621) (flutter/flutter#120702) * 9d94a51b6 Move linux-x64-flutter-gtk.zip to linux-x64-debug location. (flutter/flutter#120658) * d29668ddb Improve network resources doctor check (flutter/flutter#120417) * 378668db4 added MaterialStateColor support to TabBarTheme.labelColor (flutter/flutter#109541) * ba46cb8d5 Remove deprecated AppBar.color & AppBar.backwardsCompatibility (flutter/flutter#120618) * 5a3957f3b Revert "Fix error when resetting configurations in tear down phase" (flutter/flutter#120739) * fd01812f6 Add temporary default case to support new PointerSignalKind (flutter/flutter#120731) * 4b8ad1b00 Temporarily disable info-based analyzer unit tests. (flutter/flutter#120753) * 911b13784 Roll Flutter Engine from d860892528ff to 44e36c9c0d73 (20 revisions) (flutter/flutter#120761) * 4ae5252f8 Fix license page crash (flutter/flutter#120728) * 31c73fcfe Roll Flutter Engine from 44e36c9c0d73 to bf7d51586704 (2 revisions) (flutter/flutter#120772) * 624445a45 Roll Flutter Engine from bf7d51586704 to ec70b5aa96be (2 revisions) (flutter/flutter#120781) * df41e58f6 1328c4bc6 Roll Dart SDK from 0456c4011cb3 to c022d475e9d8 (1 revision) (flutter/engine#39646) (flutter/flutter#120784)

…16() (flutter/flutter#109729)

* 001c495 Roll Flutter Engine from 9a40a384997d to e1d0032029e4 (6 revisions) (flutter/flutter#120414) * 96823590e post submit only (flutter/flutter#120411) * 5dbd28101 Use String.codeUnitAt instead of String.codeUnits[] in ParagraphBoundary (flutter/flutter#120234) * f05a555bc Fix lerping for `NavigationRailThemeData` icon themes (flutter/flutter#120066) * b0d04ea49 add9e11ed Fix position of BackdropFilter above PlatformView (flutter/engine#39244) (flutter/flutter#120415) * 858f94cfa Roll Plugins from 73986f4 to 02571ec (3 revisions) (flutter/flutter#120443) * 298c874ea Fix classes that shouldn't be extended/instantiated/mixedin (flutter/flutter#120409) * 25c2c22d2 Delete Chrome temp cache after closing (flutter/flutter#119062) * b2e37c659 [conductor] Tag engine versions (flutter/flutter#120419) * 780c9a8de Remove deprecated SystemChrome.setEnabledSystemUIOverlays (flutter/flutter#119576) * 52ab29936 Roll Flutter Engine from add9e11edb66 to 4104eb5cbc40 (14 revisions) (flutter/flutter#120470) * 65fd924d8 [conductor] Remove CiYaml model (flutter/flutter#120458) * d5dbcb708 Revert "Revert "[web] Move JS content to its own `.js` files (#117691)" (#120275)" (flutter/flutter#120363) * 2f9abd20f Roll Flutter Engine from 4104eb5cbc40 to 6660300ea34f (6 revisions) (flutter/flutter#120487) * d63c54c9c roll packages (flutter/flutter#120493) * 941578ea9 Roll Flutter Engine from 6660300ea34f to 5e3ff1e5c9b3 (4 revisions) (flutter/flutter#120495) * b3613c4cf f737dc868 [macOS] Add XCode marks for TextInputPlugin (flutter/engine#39550) (flutter/flutter#120501) * 4ab2ffd58 Roll Flutter Engine from f737dc868a3e to 3ac3338489d2 (2 revisions) (flutter/flutter#120505) * 859d57b3c 8baee2164 Roll Skia from 5230650dc096 to 70a3a194ec98 (2 revisions) (flutter/engine#39554) (flutter/flutter#120507) * e42ab1cb0 c3dc68e0e Roll Skia from 70a3a194ec98 to 6c3097e6f833 (1 revision) (flutter/engine#39555) (flutter/flutter#120508) * 61e059f44 Roll Flutter Engine from c3dc68e0e263 to 363355af5158 (2 revisions) (flutter/flutter#120511) * d27de1de0 5efb42971 Roll Fuchsia Linux SDK from 482Njb1v72P7fNyj4... to MVMTNxWJaWdwPWstz... (flutter/engine#39559) (flutter/flutter#120512) * bbf8446d9 761891200 Roll Dart SDK from 1d26a1d57edf to b1836aacc08a (1 revision) (flutter/engine#39561) (flutter/flutter#120513) * 0346f4b18 d8e01097e Roll Fuchsia Mac SDK from 6nMZjuYXTcnD_VZQI... to FxFPRn_9rSWWAWFw0... (flutter/engine#39562) (flutter/flutter#120519) * 0db47bdd0 Revert "Fix BottomAppBar & BottomSheet M3 shadow (#119819)" (flutter/flutter#120492) * f04600bfb Roll Flutter Engine from d8e01097e66b to 2cba062f9f4c (2 revisions) (flutter/flutter#120538) * 274f6cb2d Roll Flutter Engine from 2cba062f9f4c to 05d81c0f2ebe (2 revisions) (flutter/flutter#120547) * d6ff0f2af fe56a45b4 Roll Dart SDK from c4255cea566a to 1caf3a9ad101 (1 revision) (flutter/engine#39571) (flutter/flutter#120552) * 7295d4fe9 9a19d7eea Roll Fuchsia Linux SDK from arbaBzyUE2ok1bGl5... to 8fdyKaKQqTPpjcp-L... (flutter/engine#39572) (flutter/flutter#120554) * 6d68eb7b8 0aa4fcbd2 Roll Skia from ec87ec6fd34f to 615965d545f4 (1 revision) (flutter/engine#39573) (flutter/flutter#120558) * 527977b6a b7e80ad6e Roll Fuchsia Mac SDK from y35kWL0rP5Nd06lTg... to KpTOXssqVhPv2OBZi... (flutter/engine#39574) (flutter/flutter#120559) * 238b0dbc0 Roll Flutter Engine from b7e80ad6ef51 to 1ff345ce5f63 (2 revisions) (flutter/flutter#120574) * 3e659cf71 1eef041d4 [Impeller] Source the pipeline color attachment pixel format from RenderPass textures (flutter/engine#39556) (flutter/flutter#120576) * 53fe8a3f9 4107a7b71 Roll Skia from 615965d545f4 to c6f1de2239fb (1 revision) (flutter/engine#39581) (flutter/flutter#120580) * b0c24e8d3 fix a Slider theme update bug (flutter/flutter#120432) * b33c76f01 1695b7bbc Bump github/codeql-action from 2.1.39 to 2.2.4 (flutter/engine#39584) (flutter/flutter#120588) * ce8efb439 ede2a0a3c Roll Skia from c6f1de2239fb to d85501fa487d (1 revision) (flutter/engine#39585) (flutter/flutter#120593) * 7fb8497b5 Roll Plugins from 02571ec to f3bc6f1 (2 revisions) (flutter/flutter#120601) * 7c2d5b9c2 60c8532d6 Roll Fuchsia Mac SDK from NZAnfCkpbswhYplty... to 6hbPQq6ED0PkuQiKM... (flutter/engine#39587) (flutter/flutter#120602) * 1f268f1d6 fb8840578 Roll Dart SDK from 1caf3a9ad101 to f80c5db8736a (1 revision) (flutter/engine#39588) (flutter/flutter#120606) * 957494d9f Marks Linux_android flavors_test to be unflaky (flutter/flutter#120299) * 0792c2795 Roll Flutter Engine from fb8840578156 to df0ffe42b33e (2 revisions) (flutter/flutter#120607) * 7bacc25ee Remove accentColorBrightness usage (flutter/flutter#120577) * 98576cef5 Avoid null terminating characters in strings from Utf8FromUtf16() (flutter/flutter#109729) * 00adf9a33 roll packages (flutter/flutter#120609) * 2df140f40 Remove references to Observatory (flutter/flutter#118577) * a819d6156 Remove `prefer_equal_for_default_values` lint rule (flutter/flutter#120533) * 73afc7ba3 Roll Flutter Engine from df0ffe42b33e to 97dcf3e6201e (4 revisions) (flutter/flutter#120617) * f858302a6 Remove `brightness` from `AppBar`/`SliverAppBar`/`AppBarTheme`/`AppBarTheme.copyWith` (flutter/flutter#120575) * 95fd821ab Force `Mac build_tests` to run on x64 bots (flutter/flutter#120620) * ed35c80d2 d28cbf402 [Impeller] Return entity from filters instead of a snapshot (flutter/engine#39560) (flutter/flutter#120625) * 778b3fa32 support updating dragDecices at runtime (flutter/flutter#120336) * ddebe833b Added integration test for wide gamut support. (flutter/flutter#119657) * becb6bd00 Fix message type inconsistency between locales (flutter/flutter#120129) * f4495f5d3 Roll Flutter Engine from d28cbf402904 to 31a4648cbe99 (2 revisions) (flutter/flutter#120630) * 402caec2e Fix `ListTile`'s default `iconColor` token used & update examples (flutter/flutter#120444) * 865422da2 Force `Mac tool_integration_tests` to run on x64 bots (flutter/flutter#120634) * 07c548c69 Apply BindingBase.checkInstance to TestDefaultBinaryMessengerBinding (flutter/flutter#116937) * b08cc8be7 Roll Flutter Engine from 31a4648cbe99 to c4f51bc78644 (7 revisions) (flutter/flutter#120656) * 6a94f25a9 Roll Flutter Engine from c4f51bc78644 to 17ab09d382e3 (5 revisions) (flutter/flutter#120664) * b0edf5829 Roll Flutter Engine from 17ab09d382e3 to cbb7fc020b00 (2 revisions) (flutter/flutter#120673) * 17b4c70ff [M3] Add customizable overflow property to Snackbar's action (flutter/flutter#120394) * b35e4a54f Roll Plugins from f3bc6f1 to 9c312d4 (2 revisions) (flutter/flutter#120694) * 9fd34048f f4fcb911b Roll Skia from bb7b22f3f444 to 8de7f68a3661 (1 revision) (flutter/engine#39619) (flutter/flutter#120699) * b9b4d3e43 roll packages (flutter/flutter#120628) * ed5bd1779 Fix tree by updating dependencies (flutter/flutter#120707) * 480c54c37 Increase Linux docs_publish timeout (flutter/flutter#120718) * c102bf467 [integration_test] Fix link to integration test for web section in `README.md` (flutter/flutter#103422) * 577ad2ee8 Fix error when resetting configurations in tear down phase (flutter/flutter#114468) * 2cfca820a Force Mac plugin_test to run on x64 bots (flutter/flutter#120714) * fd2fd94e3 d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to EFcCpAxOuQllDqP0F... (flutter/engine#39621) (flutter/flutter#120702) * 9d94a51b6 Move linux-x64-flutter-gtk.zip to linux-x64-debug location. (flutter/flutter#120658) * d29668ddb Improve network resources doctor check (flutter/flutter#120417) * 378668db4 added MaterialStateColor support to TabBarTheme.labelColor (flutter/flutter#109541) * ba46cb8d5 Remove deprecated AppBar.color & AppBar.backwardsCompatibility (flutter/flutter#120618) * 5a3957f3b Revert "Fix error when resetting configurations in tear down phase" (flutter/flutter#120739) * fd01812f6 Add temporary default case to support new PointerSignalKind (flutter/flutter#120731) * 4b8ad1b00 Temporarily disable info-based analyzer unit tests. (flutter/flutter#120753) * 911b13784 Roll Flutter Engine from d860892528ff to 44e36c9c0d73 (20 revisions) (flutter/flutter#120761) * 4ae5252f8 Fix license page crash (flutter/flutter#120728) * 31c73fcfe Roll Flutter Engine from 44e36c9c0d73 to bf7d51586704 (2 revisions) (flutter/flutter#120772) * 624445a45 Roll Flutter Engine from bf7d51586704 to ec70b5aa96be (2 revisions) (flutter/flutter#120781) * df41e58f6 1328c4bc6 Roll Dart SDK from 0456c4011cb3 to c022d475e9d8 (1 revision) (flutter/engine#39646) (flutter/flutter#120784)

loic-sharma added the a: desktop Running on desktop label Aug 18, 2022

loic-sharma reviewed Aug 18, 2022

View reviewed changes

packages/flutter_tools/templates/app_shared/windows.tmpl/runner/utils.cpp Outdated Show resolved Hide resolved

loic-sharma reviewed Aug 18, 2022

View reviewed changes

packages/flutter_tools/templates/app_shared/windows.tmpl/runner/utils.cpp Outdated Show resolved Hide resolved

loic-sharma reviewed Aug 18, 2022

View reviewed changes

packages/flutter_tools/templates/app_shared/windows.tmpl/runner/utils.cpp Outdated Show resolved Hide resolved

cbracken requested changes Aug 18, 2022

View reviewed changes

tgucio requested a review from cbracken August 30, 2022 16:35

cbracken approved these changes Sep 23, 2022

View reviewed changes

cbracken reviewed Sep 23, 2022

View reviewed changes

cbracken self-requested a review September 23, 2022 00:13

cbracken previously requested changes Sep 23, 2022

View reviewed changes

gspencergoog marked this pull request as draft September 29, 2022 18:15

yaakovschectman mentioned this pull request Jan 17, 2023

[Windows] Test template files' utils.h functions. #118644

Closed

cbracken marked this pull request as ready for review January 26, 2023 19:13

loic-sharma requested a review from yaakovschectman January 30, 2023 18:42

engine-flutter-autoroll mentioned this pull request Feb 14, 2023

Roll Flutter from e3471f08d1d3 to 17b4c70ff5fb (62 revisions) flutter/plugins#7177

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

c8066aa

…16() (flutter/flutter#109729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

98576cef5 Avoid null terminating characters in strings from Utf8FromU…

0b44593

…tf16() (flutter/flutter#109729)

This was referenced Feb 14, 2023

Roll Flutter from ce8efb439e74 to b35e4a54fd4b (26 revisions) flutter/packages#3202

Closed

Roll Flutter from e3471f08d1d3 to b35e4a54fd4b (63 revisions) flutter/plugins#7178

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

7ab7c51

…16() (flutter/flutter#109729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

98576cef5 Avoid null terminating characters in strings from Utf8FromU…

e957fae

…tf16() (flutter/flutter#109729)

This was referenced Feb 14, 2023

Roll Flutter from ce8efb439e74 to 9fd34048fefa (27 revisions) flutter/packages#3203

Closed

Roll Flutter from e3471f08d1d3 to 9fd34048fefa (64 revisions) flutter/plugins#7179

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

6785227

…16() (flutter/flutter#109729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

98576cef5 Avoid null terminating characters in strings from Utf8FromU…

1883aa6

…tf16() (flutter/flutter#109729)

This was referenced Feb 14, 2023

Roll Flutter from e3471f08d1d3 to b9b4d3e43e24 (65 revisions) flutter/plugins#7180

Closed

Roll Flutter from ce8efb439e74 to b9b4d3e43e24 (28 revisions) flutter/packages#3204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

98576cef5 Avoid null terminating characters in strings from Utf8FromU…

a542041

…tf16() (flutter/flutter#109729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

6f7b442

…16() (flutter/flutter#109729)

This was referenced Feb 14, 2023

Roll Flutter from ce8efb439e74 to ed5bd177944c (29 revisions) flutter/packages#3205

Closed

Roll Flutter from e3471f08d1d3 to ed5bd177944c (66 revisions) flutter/plugins#7182

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

3f1e5bd

…16() (flutter/flutter#109729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

98576cef5 Avoid null terminating characters in strings from Utf8FromU…

e9e2cdd

…tf16() (flutter/flutter#109729)

This was referenced Feb 15, 2023

Roll Flutter from e3471f08d1d3 to df41e58f6f4e (83 revisions) flutter/plugins#7184

Merged

Roll Flutter from ce8efb439e74 to df41e58f6f4e (46 revisions) flutter/packages#3207

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 15, 2023

98576cef5 Avoid null terminating characters in strings from Utf8FromU…

047ca34

…tf16() (flutter/flutter#109729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

924966d

…16() (flutter/flutter#109729)

tgucio mentioned this pull request Feb 22, 2023

Remove outdated TODO #121200

Merged

8 tasks

tgucio deleted the win32-strings branch February 22, 2023 08:58

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

4605978

…16() (flutter/flutter#109729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

98576ce Avoid null terminating characters in strings from Utf8FromUtf…

d2b8cae

…16() (flutter/flutter#109729)

Avoid null terminating characters in strings from Utf8FromUtf16() #109729

Avoid null terminating characters in strings from Utf8FromUtf16() #109729

Uh oh!

Conversation

tgucio commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 17, 2022

Uh oh!

tgucio commented Aug 17, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

tgucio commented Aug 18, 2022

Uh oh!

christopherfujino commented Sep 8, 2022

Uh oh!

christopherfujino commented Sep 14, 2022

Uh oh!

Jasguerrero commented Sep 22, 2022

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

gspencergoog commented Sep 29, 2022

Uh oh!

cbracken commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgucio commented Jan 27, 2023

Uh oh!

loic-sharma commented Jan 30, 2023

Uh oh!

yaakovschectman commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tgucio commented Aug 17, 2022 •

edited

Loading

cbracken commented Jan 26, 2023 •

edited

Loading