Skip to content

Remove scheduler #109714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 17, 2022
Merged

Remove scheduler #109714

auto-submit merged 1 commit into from
Aug 17, 2022

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Aug 17, 2022 •
edited
Loading

Removes luci scheduler for spell check integration test as per #109712.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@camsim99 camsim99 requested a review from keyonghan as a code owner August 17, 2022 19:46
keyonghan
keyonghan approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Aug 17, 2022
@auto-submit auto-submit bot merged commit 5ca8c4d into flutter:master Aug 17, 2022
This was referenced Aug 18, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
5ca8c4d Remove scheduler (flutter/flutter#109714)
0953a5d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
5ca8c4d Remove scheduler (flutter/flutter#109714)
e44a57a
@gmackall gmackall mentioned this pull request Sep 10, 2024
Merged
9 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 10, 2024
@gmackall
Remove scheduler: luci from new build_aar_module_test (#154945)
6fd2b9f 
This option was deprecated (/removed?) in the time since the test was originally disabled.

See #109712, #109714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camsim99 @keyonghan