Skip to content

Started wrapping ByteData responses with unmodifiable #109707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaaclarke wants to merge 1 commit into from
Closed

Started wrapping ByteData responses with unmodifiable #109707

gaaclarke wants to merge 1 commit into from

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Aug 17, 2022 •
edited
Loading

engine pr: flutter/engine#35468
Facilitates data copy elimination in the engine.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 17, 2022
@gaaclarke gaaclarke mentioned this pull request Aug 17, 2022
Merged
8 tasks
@gaaclarke
Copy link
Member Author

gaaclarke commented Aug 17, 2022

abandoning for a full engine solution

@gaaclarke gaaclarke closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gaaclarke