Skip to content

Re-land Add Spell Check to EditableText #109643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 11 commits into from
Aug 17, 2022
Merged

Re-land Add Spell Check to EditableText #109643

auto-submit merged 11 commits into from
Aug 17, 2022

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Aug 16, 2022 •
edited
Loading

Re-lands #109334 with a fix for https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20analyze/8873/overview.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 16, 2022
@camsim99 camsim99 requested a review from justinmc August 16, 2022 23:29
@camsim99 camsim99 marked this pull request as ready for review August 16, 2022 23:29
@camsim99 camsim99 requested a review from keyonghan as a code owner August 16, 2022 23:29
@camsim99
Copy link
Contributor Author

camsim99 commented Aug 16, 2022

@justinmc The fix for the failed test is here https://github.com/flutter/flutter/pull/109643/files#diff-1ae099567a7a5b9a2a2be57a54b37ee411f3bbd94cdcdbaf8692ec46c8c642cfR17-R22.

justinmc
justinmc approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reland LGTM 👍

I wonder why this docs analyzer error wasn't caught before merge last time?

Edit: I asked on Discord: https://discord.com/channels/608014603317936148/608021351567065092/1009491652395679886

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2022
@auto-submit auto-submit bot merged commit 7db25c3 into flutter:master Aug 17, 2022
keyonghan
keyonghan reviewed Aug 17, 2022
View reviewed changes
.ci.yaml
tags: >
["devicelab", "android", "linux"]
task_name: spell_check_test
scheduler: luci
Copy link
Contributor

@keyonghan keyonghan Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have caught this earlier.
Now everything is with cocoon scheduling, and we should remove the scheduler: luci.
I created #109712 to track the doc update.

This was referenced Aug 18, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
7db25c3 Re-land Add Spell Check to EditableText (flutter/flutter#109643)
b28f268
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
7db25c3 Re-land Add Spell Check to EditableText (flutter/flutter#109643)
cc196c0
@camsim99 camsim99 mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

+1 more reviewer

@keyonghan keyonghan keyonghan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camsim99 @justinmc @keyonghan