Skip to content

109638: Windows framework_tests_misc is 2.06% flaky #109640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 17, 2022
Merged

109638: Windows framework_tests_misc is 2.06% flaky #109640

auto-submit merged 1 commit into from
Aug 17, 2022

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Aug 16, 2022 •
edited
Loading

Adjusted and did some cleanup in live_widget_controller_test.dart to avoid test flakiness.

  • Changed wiggle room for "Input event array on LiveWidgetController" from -1 to -7 to reduce flakiness
  • Removed unused hitTestHistory variable from LiveWidgetController.handlePointerEventRecord.

Works around 109323.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pdblasi-google
109638: Windows framework_tests_misc is 2.06% flaky
be3ef73 
Adjusted and did some cleanup in `live_widget_controller_test.dart` to avoid test flakiness.
* Changed wiggle room for "Input event array on LiveWidgetController" from -1 to -7 to reduce flakiness
* Removed unused `hitTestHistory` variable from `LiveWidgetController.handlePointerEventRecord`.
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 16, 2022
dkwingsmt
dkwingsmt approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if I have the say.

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2022
@auto-submit auto-submit bot merged commit c8c3f39 into flutter:master Aug 17, 2022
@pdblasi-google pdblasi-google deleted the issue/109638 branch August 17, 2022 21:04
This was referenced Aug 18, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
c8c3f39 109638: Windows framework_tests_misc is 2.06% flaky (flutter/…
b7f680d 
…flutter#109640)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
c8c3f39 109638: Windows framework_tests_misc is 2.06% flaky (flutter/…
268b361 
…flutter#109640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pdblasi-google @dkwingsmt