Skip to content

update our build bot exclusions #10964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devoncarew merged 1 commit into from
Jun 26, 2017
Merged

update our build bot exclusions #10964

devoncarew merged 1 commit into from
Jun 26, 2017

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Jun 25, 2017

  • add one more env var to recognize chrome bots (BUILDBOT_BUILDERNAME)
  • switch the method we use to recognize bots on windows. We were using env var == comparisons, generally to true; however the appveyor docs say the value will be True. In order to avoid case issues, we now just check for the presence of the key.

@tvolkert @Hixie

tvolkert
tvolkert approved these changes Jun 26, 2017
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devoncarew devoncarew merged commit f946171 into flutter:master Jun 26, 2017
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
@devoncarew @gspencergoog
update our build bot exclusions (flutter#10964)
ada077f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devoncarew @tvolkert @googlebot