Scrollbar respect the NeverScrollableScrollPhysics physics #109609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: scrolling
Piinks
approved these changes
Aug 16, 2022
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
This made me chuckle. Thank you for finding and fixing this!
LGTM
Contributor
This is a good point, but it is possible to have a scrollbar just serve as a passive indicator of scroll position. Someone could have |
xu-baolin
added
the
autosubmit
This was referenced Aug 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can scroll the scrollable widget with
NeverScrollableScrollPhysicsby the scroll bar.I am not sure whether need hide the bar if the scrollable do not allow user scroll