Skip to content

Revert "Refactor StrokeAlign to allow double values." #109591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 16, 2022
Merged

Revert "Refactor StrokeAlign to allow double values." #109591

auto-submit merged 1 commit into from
Aug 16, 2022

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Aug 16, 2022 •
edited by HansMuller
Loading

Reverts #108339

#108339 removed the StrokeAlign enum. That's a breaking change and it caused many internal test failures due to a StrokeAlign dependency.

Failures reported in Google-internal issue b/242668688

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 16, 2022
@CaseyHillers CaseyHillers mentioned this pull request Aug 16, 2022
Merged
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2022
@auto-submit auto-submit bot merged commit 370fc48 into master Aug 16, 2022
@auto-submit auto-submit bot deleted the revert-108339-StrokeAlign-v2 branch August 16, 2022 06:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2022
@engine-flutter-autoroll
370fc48 Revert "Refactor StrokeAlign to allow double values." (flutte…
5fbcce8 
…r/flutter#109591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 17, 2022
@engine-flutter-autoroll
370fc48 Revert "Refactor StrokeAlign to allow double values." (flutte…
094dea3 
…r/flutter#109591)
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Aug 18, 2022
@gspencergoog
Re-Land "Refactor StrokeAlign to allow double values." (flutter#109591)
925732e 
This reverts commit 370fc48 so that it can be re-landed.
auto-submit bot pushed a commit that referenced this pull request Aug 19, 2022
@gspencergoog
Re-Land "Refactor StrokeAlign to allow double values." (#109591) (#10…
b3aba4d 
…9805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

1 more reviewer

@muditatandon muditatandon muditatandon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaseyHillers @muditatandon