Fix --keep-app-running default and make devicelab verboser #10957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
commented
Jun 24, 2017
| DriveCommand() { | ||
| argParser.addFlag( | ||
| 'keep-app-running', | ||
| defaultsTo: null, |
Contributor
Author
There was a problem hiding this comment.
this is the line required to fix the build; the rest is just the debugging logic i added to track down the problem.
yjbanov
approved these changes
Jun 24, 2017
|
|
||
| process.exitCode.whenComplete(() { | ||
| print('\n'); // separate the output of this script from subsequent output to make logs easier to read | ||
| process.exitCode.then((int exitCode) { |
Contributor
There was a problem hiding this comment.
Not sure if it matters for exitCode, but the difference between whenComplete and then is that whenComplete will also trigger if there's an error.
Contributor
Author
There was a problem hiding this comment.
Yeah. exitCode won't ever fail though, and whenComplete doesn't give me the value.
Contributor
Author
|
Landing on red to fix breakage. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @yjbanov