Skip to content

Reland "Keep dirty manipulations private to Element base class (#109401)" #109562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 15, 2022
Merged

Reland "Keep dirty manipulations private to Element base class (#109401)" #109562

auto-submit merged 2 commits into from
Aug 15, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Aug 15, 2022

This reverts commit 7887ca5.

First commit is a straight reland of the change. The fix for the test that was broken by that change is in the second commit.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 15, 2022
gspencergoog
gspencergoog approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 15, 2022

  • The status or check suite Windows build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2022
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2022
@auto-submit auto-submit bot merged commit 2b9beda into flutter:master Aug 15, 2022
@goderbauer goderbauer deleted the revertDirty branch August 15, 2022 20:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2022
@engine-flutter-autoroll
2b9beda Reland "Keep dirty manipulations private to Element base …
9ccbbaf 
…class (#109401)" (flutter/flutter#109562)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 17, 2022
@engine-flutter-autoroll
2b9beda Reland "Keep dirty manipulations private to Element base …
f88ad34 
…class (#109401)" (flutter/flutter#109562)
goderbauer added a commit to goderbauer/flutter that referenced this pull request Aug 17, 2022
@goderbauer
Reland "Keep dirty manipulations private to Element base class (f…
ab923dd 
…lutter#109401)" (flutter#109562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @gspencergoog