Skip to content

Some changes needed to PlatformMenuBar before the MenuBar implementation change lands. #109556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 16, 2022
Merged

Some changes needed to PlatformMenuBar before the MenuBar implementation change lands. #109556

auto-submit merged 1 commit into from
Aug 16, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Aug 15, 2022 •
edited
Loading

Description

This removes the connection between MenuBar (not yet committed) and the platform menu bar, by removing the MenuItem class, and replacing it with PlatformMenuItem.

Related Issues

Tests

  • Adjusted the tests

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 15, 2022
@gspencergoog gspencergoog mentioned this pull request Aug 15, 2022
Closed
@gspencergoog gspencergoog force-pushed the menu_bar_platform branch 2 times, most recently from 7233896 to b7cb16a Compare August 15, 2022 19:43
@gspencergoog gspencergoog marked this pull request as ready for review August 15, 2022 23:47
goderbauer
goderbauer approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming dropping MenuItem doesn't break any customer tests or google3.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2022
@auto-submit auto-submit bot merged commit cd98c49 into flutter:master Aug 16, 2022
@gspencergoog gspencergoog deleted the menu_bar_platform branch August 16, 2022 23:12
This was referenced Aug 17, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2022
@engine-flutter-autoroll
cd98c49 Some changes needed to PlatformMenuBar before the MenuBar imp…
2fa38c8 
…lementation change lands. (flutter/flutter#109556)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 17, 2022
@engine-flutter-autoroll
cd98c49 Some changes needed to PlatformMenuBar before the MenuBar imp…
b65316d 
…lementation change lands. (flutter/flutter#109556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gspencergoog @goderbauer