-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add Compilation DeviceLab test for Windows #109540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaakovschectman
merged 17 commits into
flutter:master
from
yaakovschectman:devicelab_init_windows
Aug 15, 2022
Merged
Add Compilation DeviceLab test for Windows #109540
yaakovschectman
merged 17 commits into
flutter:master
from
yaakovschectman:devicelab_init_windows
Aug 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Aug 15, 2022
keyonghan
reviewed
Aug 15, 2022
Contributor
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci yaml LGTM.
…lutter into devicelab_init_windows
cbracken
reviewed
Aug 15, 2022
cbracken
reviewed
Aug 15, 2022
cbracken
approved these changes
Aug 15, 2022
Member
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo comments.
1f63d95 to
588e29e
Compare
588e29e to
3be81c1
Compare
Re triggering tests
3be81c1 to
b35e083
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 17, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: desktop
Running on desktop
c: contributor-productivity
Team-specific productivity, code health, technical debt.
d: examples
Sample code and demos
platform-windows
Building on or for Windows specifically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces "Unsupported operation" exceptions in
perf_tests.dartfor Windows OS with a call to the flutter build command for Windows, so that Windows DeviceLab tests can be run. Also adds a compilation test task for Windows,hello_world_windows__compile, and a target to.ci.yamlto test it. In order to run the newly added task, I also needed to create a windows target build for thehello_worldexample project.As I do not believe there is any way to test the
.ci.yamltargets locally, please look over my configuration if you are familiar with these targets to corroborate sure it is correct.Addresses issue #70027
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.