Skip to content

Conversation

@yaakovschectman
Copy link
Contributor

Replaces "Unsupported operation" exceptions in perf_tests.dart for Windows OS with a call to the flutter build command for Windows, so that Windows DeviceLab tests can be run. Also adds a compilation test task for Windows, hello_world_windows__compile, and a target to .ci.yaml to test it. In order to run the newly added task, I also needed to create a windows target build for the hello_world example project.

As I do not believe there is any way to test the .ci.yaml targets locally, please look over my configuration if you are familiar with these targets to corroborate sure it is correct.

Addresses issue #70027

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yaakovschectman yaakovschectman added platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Aug 15, 2022
@yaakovschectman yaakovschectman self-assigned this Aug 15, 2022
@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 15, 2022
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci yaml LGTM.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo comments.

Re triggering tests
@yaakovschectman yaakovschectman merged commit bba2ac8 into flutter:master Aug 15, 2022
@yaakovschectman yaakovschectman deleted the devicelab_init_windows branch August 15, 2022 20:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-windows Building on or for Windows specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants