Skip to content

Revert "Keep dirty manipulations private to Element base class (#109401)" #109481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 1 commit into from
Aug 13, 2022
Merged

Revert "Keep dirty manipulations private to Element base class (#109401)" #109481

gspencergoog merged 1 commit into from
Aug 13, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Aug 13, 2022

This reverts commit a624cb7 because it appears to have broken the build.

@gspencergoog
Revert "Keep dirty manipulations private to Element base class (f…
46855ca 
…lutter#109401)"

This reverts commit a624cb7 because it appears to have broken the build.
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Aug 13, 2022
Renzo-Olivares
Renzo-Olivares approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog merged commit 7887ca5 into flutter:master Aug 13, 2022
This was referenced Aug 13, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
15c37c2 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
7687fbc 
…class (#109401)" (flutter/flutter#109481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
e944de4 
…class (#109401)" (flutter/flutter#109481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
1037f5b 
…class (#109401)" (flutter/flutter#109481)
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
baef6e2 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
5b53d90 
…class (#109401)" (flutter/flutter#109481)
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
334dc2b 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
28d9074 
…class (#109401)" (flutter/flutter#109481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
6d3642b 
…class (#109401)" (flutter/flutter#109481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
04b0cb4 
…class (#109401)" (flutter/flutter#109481)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
bbf3c1e 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
98e3a22 
…class (#109401)" (flutter/flutter#109481)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
3b27113 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
354dba5 
…class (#109401)" (flutter/flutter#109481)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
e446c2a 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
795f5af 
…class (#109401)" (flutter/flutter#109481)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
c554a61 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
0183a22 
…class (#109401)" (flutter/flutter#109481)
This was referenced Aug 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
190bfcc 
…class (#109401)" (flutter/flutter#109481)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
7887ca5 Revert "Keep dirty manipulations private to Element base …
827ce8b 
…class (#109401)" (flutter/flutter#109481)
stuartmorgan-g pushed a commit to flutter/plugins that referenced this pull request Aug 16, 2022
@engine-flutter-autoroll
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (#6275)
ba27a65 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
camsim99 pushed a commit to camsim99/plugins that referenced this pull request Aug 23, 2022
@engine-flutter-autoroll @camsim99
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (flutter#6275)
11a49bb 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll @moisefeelin
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (flutter#6275)
399d6db 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (flutter#6275)
29585ff 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gspencergoog @Renzo-Olivares