-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[CP] Remove deprecated Ruby File.exists? in helper script #109475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
See test-exemption from original PR #109428 (comment)
|
|
Hey @jmagman can this be merged or luci-flutter test retried as that is the one which is failing currently. |
|
Closing, #110045 was merged. |
Limited cherry-pick of #109428 that only has the deprecation method replacement without the other lint fixes. Limited the cp to just this line to reduce risk.
Re lack of testing:
Fixes #109476