Lazily initialise Xcode installation status #10945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than pre-compute Xcode install path, version, and EULA status, compute and cache on demand.
Member
Author
|
Pre-factoring before making these calls async. |
tvolkert
reviewed
Jun 23, 2017
| bool get isInstalled => _isInstalled; | ||
| bool get isInstalled { | ||
| if (xcodeSelectPath != null && xcodeSelectPath.isNotEmpty) | ||
| return false; |
Member
Author
There was a problem hiding this comment.
Whoops - tried to get clever, realised it wouldn't work and missed a revert. Once this is in, asyncified and the process invocations extracted, we'll be able to easily add tests for these cases.
tvolkert
reviewed
Jun 23, 2017
| if (!xcodeVersionRegex.hasMatch(xcodeVersionText)) | ||
| return false; | ||
| if (!eulaSigned) | ||
| return false; |
Contributor
There was a problem hiding this comment.
This doesn't match the previous logic
tvolkert
approved these changes
Jun 23, 2017
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Jun 23, 2017
This reverts commit bb8e2a7. Triggers a doctor failure on the Mac chromebots.
cbracken
added a commit
that referenced
this pull request
Jun 23, 2017
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Rather than pre-compute Xcode install path, version, and EULA status, compute and cache on demand.
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
…lutter#10951) This reverts commit bb8e2a7. Triggers a doctor failure on the Mac chromebots.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than pre-compute Xcode install path, version, and EULA status,
compute and cache on demand.