Skip to content

Reland: Set IconButton.visualDensity default to VisualDensity.standard #109432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 4 commits into from
Aug 18, 2022
Merged

Reland: Set IconButton.visualDensity default to VisualDensity.standard #109432

QuncCccccc merged 4 commits into from
Aug 18, 2022

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Aug 12, 2022

This pr re-lands #109349 and fixes #64702

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 12, 2022
@QuncCccccc QuncCccccc requested a review from HansMuller August 12, 2022 17:03
@QuncCccccc QuncCccccc marked this pull request as ready for review August 12, 2022 17:04
HansMuller
HansMuller approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@QuncCccccc QuncCccccc merged commit 79013b2 into flutter:master Aug 18, 2022
This was referenced Aug 19, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2022
@engine-flutter-autoroll
79013b2 Reland: Set IconButton.visualDensity default to VisualDensity…
16b9a7f 
….standard (flutter/flutter#109432)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 19, 2022
@engine-flutter-autoroll
79013b2 Reland: Set IconButton.visualDensity default to VisualDensity…
db004e4 
….standard (flutter/flutter#109432)
@itsjustkevin itsjustkevin mentioned this pull request Aug 23, 2022
Merged
QuncCccccc added a commit that referenced this pull request Aug 23, 2022
@QuncCccccc
Revert "Reland: Set IconButton.visualDensity default to VisualDensity…
6b894e7 
….standard (#109432)"

This reverts commit 79013b2.
@QuncCccccc QuncCccccc mentioned this pull request Aug 23, 2022
Merged
QuncCccccc added a commit that referenced this pull request Aug 23, 2022
@QuncCccccc
Revert "Reland: Set IconButton.visualDensity default to VisualDensity…
c0c3874 
….standard (#109432)" (#110119)

This reverts commit 79013b2.
@itsjustkevin itsjustkevin mentioned this pull request Aug 24, 2022
Merged
itsjustkevin added a commit that referenced this pull request Aug 24, 2022
@itsjustkevin @QuncCccccc
Revert "Reland: Set IconButton.visualDensity default to VisualDensity…
0696d53 
….standard (#109432)" (#110119) (#110136)

This reverts commit 79013b2.

Co-authored-by: Qun Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IconButton's splash radius is too large on an AppBar

2 participants

@QuncCccccc @HansMuller