Skip to content

Revert "Set IconButton.visualDensity default to VisualDensity.standard" #109421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 1 commit into from
Aug 11, 2022
Merged

Revert "Set IconButton.visualDensity default to VisualDensity.standard" #109421

QuncCccccc merged 1 commit into from
Aug 11, 2022

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Aug 11, 2022

Reverts #109349

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 11, 2022
gspencergoog
gspencergoog approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@QuncCccccc QuncCccccc marked this pull request as ready for review August 11, 2022 22:29
@QuncCccccc QuncCccccc merged commit 625d96a into master Aug 11, 2022
@QuncCccccc QuncCccccc deleted the revert-109349-icon_button_on_appbar_fix branch August 11, 2022 22:29
QuncCccccc added a commit that referenced this pull request Aug 11, 2022
@QuncCccccc
Revert "Revert "Set IconButton.visualDensity default to `VisualDens…
64528c3 
…ity.standard` (#109349)" (#109421)"

This reverts commit 625d96a.
QuncCccccc added a commit to QuncCccccc/flutter that referenced this pull request Aug 12, 2022
@QuncCccccc
Revert "Revert "Set IconButton.visualDensity default to `VisualDens…
4e3ed8a 
…ity.standard` (flutter#109349)" (flutter#109421)"

This reverts commit 625d96a.
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
8e7a75c 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
c586896 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
c163985 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
8abbed9 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
b3dc021 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
b7187ed 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
ae6bc4f 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
00b76a9 
…ity.standard` (#109349)" (flutter/flutter#109421)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 12, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
eb6baf7 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
d25a585 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
580cd6d 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
3e790bc 
…ity.standard` (#109349)" (flutter/flutter#109421)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
1e5b4f4 
…ity.standard` (#109349)" (flutter/flutter#109421)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
61809ce 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
8d6312b 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
45111b2 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
c7097f0 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
b9b6b78 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
7054440 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
20aa3e8 
…ity.standard` (#109349)" (flutter/flutter#109421)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
6db4b33 
…ity.standard` (#109349)" (flutter/flutter#109421)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
625d96a Revert "Set IconButton.visualDensity default to `VisualDens…
724c431 
…ity.standard` (#109349)" (flutter/flutter#109421)
QuncCccccc added a commit that referenced this pull request Aug 18, 2022
@QuncCccccc
Reland: Set IconButton.visualDensity default to VisualDensity.standard (
79013b2 
#109432)

* Revert "Revert "Set `IconButton.visualDensity` default to `VisualDensity.standard` (#109349)" (#109421)"

Co-authored-by: Qun Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @gspencergoog