Add Spellcheck to EditableText (Android) #109334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
justinmc
approved these changes
Aug 10, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM with nits. Mainly just the question about making some functions private.
| text: text.substring(composingRegion.start, composingRegion.end) | ||
| ) | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
I don't see a problem with keeping everything here in its own file in the widgets library 👍 . Unless @camsim99 or another reviewer has a better idea.
Contributor
Author
There was a problem hiding this comment.
Will definitely be useful to group the methods together especially when the menu logic needs to be added somewhere.
Contributor
Author
|
@cyanglaz Would you be willing to give this a second look? |
camsim99
added
the
autosubmit
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 16, 2022
This reverts commit ff9fe35.
jonahwilliams
pushed a commit
that referenced
this pull request
Aug 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 17, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #104460.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.