Skip to content

Print ADB output when adb install fails #10933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 1 commit into from
Jun 23, 2017
Merged

Print ADB output when adb install fails #10933

tvolkert merged 1 commit into from
Jun 23, 2017

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Jun 23, 2017

Fixes #10929

@tvolkert tvolkert requested a review from goderbauer June 23, 2017 17:09
@cbracken
Copy link
Member

cbracken commented Jun 23, 2017

lgtm

goderbauer
goderbauer approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit f18083d into flutter:master Jun 23, 2017
@tvolkert tvolkert deleted the adb branch June 23, 2017 21:08
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
@tvolkert @gspencergoog
Print ADB output when adb install fails (flutter#10933)
b6330b6 
Fixes flutter#10929
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken cbracken approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flutter tool should print adb error

4 participants

@tvolkert @cbracken @goderbauer @googlebot