Require Xcode >= 8.0 for iOS development #10932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to take advantage of improved command-line tooling (e.g., improvements in device listing in Instruments). Now that the engine is built with Xcode 8 and the framework is tested against Xcode 8, this reduces the set of configurations we need to support to allow us to focus on the supported ones: Xcode 8 and Xcode 9.
tvolkert
reviewed
Jun 23, 2017
| // Make sure the user has specified at least the DEVELOPMENT_TEAM (for automatic Xcode 8) | ||
| // signing or the PROVISIONING_PROFILE (for manual signing or Xcode 7). | ||
| // Make sure the user has specified at least the DEVELOPMENT_TEAM (for automatic signing) | ||
| // signing or the PROVISIONING_PROFILE (for manual signing). |
Member
Author
There was a problem hiding this comment.
Done/rewritten shorter.
Contributor
|
LGTM, but as discussed, a test should have ideally failed for this change, so please refactor the code such that things can get mocked out at the right level (and then fix the associated tests) |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
This allows us to take advantage of improved command-line tooling (e.g., improvements in device listing in Instruments). Now that the engine is built with Xcode 8 and the framework is tested against Xcode 8, this reduces the set of configurations we need to support to allow us to focus on the supported ones: Xcode 8 and Xcode 9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to take advantage of improved command-line tooling (e.g.,
improvements in device listing in Instruments). Now that the engine is
built with Xcode 8 and the framework is tested against Xcode 8, this
reduces the set of configurations we need to support to allow us to
focus on the supported ones: Xcode 8 and Xcode 9.