-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Bump Dart SDK version to 1.24.0 (stable) #10931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our conversation, this would bring us ahead of internal which is a trade-off we need to measure. If we're OK with that, LGTM! 👍
|
I lowered the version to 1.24.0 (stable). Will land on green. |
|
For our work on bringing new dart frontend to flutter #10841 it is critical for us to have more or less latest dart in flutter engine as there are changes being made to dart vm to accommodate new frontend work. |
|
@aam this isn't the Dart SDK version of the embedder (the engine) -- this is the Dart SDK version of the flutter tool (which is being upped from It's admittedly unfortunate and confusing that the two aren't in sync. |
|
We (rather trivially) could build our own Dart SDK on our bots and download it from the flutter_infra GCE bucket and always have the flutter/flutter version use the flutter/engine's exact Dart revision. We just haven't done it. |
|
Oops, got you, thanks! |
|
We should coordinate that with the team in Google that rolls the Dart SDK internally, since we want to make sure we don't put ourselves in a situation where we can't roll Flutter into Google because it depends on a Dart SDK version that's too far ahead of the internal SDK version. |
|
In short term, it will take some time for us to iron all kinks out flutter-with-new-frontend configuration. While we do that, new frontend functionality in flutter will be "hidden" behind configuration option ( |
#10650