Add gradle wrapper to project template #10928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mit-mit
approved these changes
Jun 23, 2017
| @@ -0,0 +1 @@ | |||
| 0b5c1398d1d04ac245a310de98825cb7b3278e2a | |||
Member
There was a problem hiding this comment.
Should we add a comment in this file describing just what this version is used for?
Contributor
Author
There was a problem hiding this comment.
That could trip up parsing. The version files for engine and material fonts do not include such a comment; file name says it all I guess.
jakobr-google
approved these changes
Jun 23, 2017
| if (location.existsSync()) | ||
| location.deleteSync(recursive: true); | ||
| location.createSync(recursive: true); | ||
| return updateInner().then<Null>((Null value) { |
Contributor
There was a problem hiding this comment.
_ instead of Null value?
This was referenced Jun 26, 2017
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
This was referenced Jul 3, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce use of gradle wrapper in project template to ensure repeatable builds. Manage gradle wrapper scripts and binary using Flutter tool cache. Update gradle and android gradle plugin versions to address #9842 and #10236.
Notes:
cache.darthas been refactored to avoid duplication across now three cached artifacts (material fonts, engine, gradle wrapper).androidfolder. These files should be checked into version control.