-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Update flutter.gradle AGP to 7.2.0 and bump default NDK version
#109211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
AndroidProject.FD_INTERMEDIATES has been deprecated. We need to find an alternative or bump to 7.1.4 for now. |
|
It seems that the new AGP simply deprecated the use of FD_INTERMEDIATES as a variable and instead just directly codes in |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
| * time of adding this code. Once released, this can be removed. | ||
| * time of adding this code. Once released, this can be removed. However, after updating to | ||
| * AGP/Gradle 7.2.0/7.5, removing this hack still causes build failures. Futher | ||
| * investigation necessary to remote this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue we can reference here in a TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me file something and add a bit more detail.
|
Addresses #105040 as we have since updated the default AGP version to 7.2.0 already.