Skip to content

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Aug 9, 2022

Addresses #105040 as we have since updated the default AGP version to 7.2.0 already.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 9, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@GaryQian
Copy link
Contributor Author

GaryQian commented Aug 9, 2022

AndroidProject.FD_INTERMEDIATES has been deprecated. We need to find an alternative or bump to 7.1.4 for now.

@GaryQian
Copy link
Contributor Author

GaryQian commented Aug 9, 2022

It seems that the new AGP simply deprecated the use of FD_INTERMEDIATES as a variable and instead just directly codes in intermediates as the directory to use. Thus, this PR now follows that example by using a top level INTERMEDIATES_DIR variable that maps to intermediates

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

* time of adding this code. Once released, this can be removed.
* time of adding this code. Once released, this can be removed. However, after updating to
* AGP/Gradle 7.2.0/7.5, removing this hack still causes build failures. Futher
* investigation necessary to remote this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue we can reference here in a TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me file something and add a bit more detail.

@GaryQian GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 15, 2022

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2022
@GaryQian GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2022
@auto-submit auto-submit bot merged commit beef848 into flutter:master Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants