Skip to content

Reland: "Add outlineVariant and scrim colors to ColorScheme" #109203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 1 commit into from
Aug 10, 2022
Merged

Reland: "Add outlineVariant and scrim colors to ColorScheme" #109203

guidezpl merged 1 commit into from
Aug 10, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Aug 9, 2022

Reland #109071, which was reverted in #109199. A g3fix will be added.

Fixes #108948

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 9, 2022
QuncCccccc
QuncCccccc approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@guidezpl guidezpl merged commit 4b7380c into flutter:master Aug 10, 2022
@guidezpl guidezpl deleted the colorscheme branch August 10, 2022 12:47
This was referenced Aug 10, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
4b7380c Add outlineVariant and scrim colors to ColorScheme (#10…
40ad62c 
…9071) (flutter/flutter#109203)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
4b7380c Add outlineVariant and scrim colors to ColorScheme (#10…
16d828e 
…9071) (flutter/flutter#109203)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
4b7380c Add outlineVariant and scrim colors to ColorScheme (#10…
24917bd 
…9071) (flutter/flutter#109203)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
4b7380c Add outlineVariant and scrim colors to ColorScheme (#10…
13c4c03 
…9071) (flutter/flutter#109203)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Add outlineVariant and scrim colors to ColorScheme (flutter#109071
360640c 
) (flutter#109203)
@guidezpl guidezpl linked an issue Aug 23, 2022 that may be closed by this pull request
Add 2 new ColorScheme color roles #106576
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add two new ColorScheme colors: outlineVariant, scrim Add 2 new ColorScheme color roles

2 participants

@guidezpl @QuncCccccc