upgrade package:usage to get clientId fix #10919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream fix is: dart-archive/usage@021664e
Member
|
LGTM |
Contributor
|
BTW, this was checked in when the tree was red. Please avoid checking anything in when the tree is red except for attempts to fix the tree. Thanks! |
Contributor
Author
|
Sorry, thought it was safe enough because everything else is green. Can rollback if this change is risky. |
Contributor
|
It's probably fine. The problem is just that we don't really know since not all the tests are actually running, so if this or anything else checked in on red did actually regress anything, we might not discover until later, at which point this would be just one checkin among many for us to try to search through when trying to find the problem. |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
The upstream fix is: dart-archive/usage@021664e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream fix was: dart-archive/usage@021664e
Absence of
clientIdcaused crash reporting to not function in the rare situation when$HOME/.flutterhas not been initialized yet.