Fix autocomplete selections #109185
Merged
Fix autocomplete selections #109185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
justinmc
approved these changes
Aug 8, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
I should have caught this when reviewing your tap region PR! Thanks for fixing this.
gspencergoog
added
the
autosubmit
This was referenced Aug 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 9, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
yjbanov
pushed a commit
to yjbanov/flutter
that referenced
this pull request
Aug 10, 2022
yjbanov
pushed a commit
to yjbanov/flutter
that referenced
this pull request
Aug 10, 2022
This was referenced Aug 10, 2022
yjbanov
pushed a commit
to yjbanov/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a problem where tapping on autocomplete suggestions would close the autocomplete window and unfocus the text field before selecting the selection.
This was due to an oversight in #107262 where I forgot to add a
TextFieldTapRegionaround the autocomplete options dialog.Related Issues
Tests