Some clarifications for ListView constructors #10907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
reviewed
Jun 22, 2017
Contributor
There was a problem hiding this comment.
The previous paragraph refers to "widgets" as children, maybe say children here as well.
HansMuller
reviewed
Jun 22, 2017
Contributor
There was a problem hiding this comment.
builder => [itemBuilder] (because just "builder" unifies with ListView.builder)
Contributor
Author
There was a problem hiding this comment.
Changed both to The 'itemBuilder' (with backticks) since it's not actually something hyperlinkable.
HansMuller
reviewed
Jun 22, 2017
Contributor
There was a problem hiding this comment.
using an item builder that returns a previously constructed widget. If the list view's children are going to be created in advance it's more efficient to use [new ListView].
Contributor
Author
There was a problem hiding this comment.
/// The `itemBuilder` should actually create the widget instances when called.
/// Avoid using a builder that returns a previously-constructed widget; if the
/// list view's children are created in advance, or all at once when the
/// [ListView] itself is created, it is more efficient to use [new ListView].
/// Even more efficient, however, is to create the instances on demand using
/// this constructor's `itemBuilder` callback.
Contributor
|
LGTM |
Contributor
Author
|
Thanks. I've pushed updates. Will land on green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @HansMuller