Skip to content

Conversation

@szakarias
Copy link
Contributor

No description provided.

Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Jun 23, 2017

Note that we're not currently uploading docs so this won't actually have any effect at first. See #10940.

@szakarias szakarias merged commit d97b13b into flutter:master Jun 26, 2017
@szakarias
Copy link
Contributor Author

Fixes #8867

@Hixie
Copy link
Contributor

Hixie commented Jun 27, 2017

Looks like this didn't actually work, but we didn't notice because we weren't uploading the docs so the code in question never got run.

@tvolkert
Copy link
Contributor

As seen in https://travis-ci.org/flutter/flutter/jobs/247597480:

Extracing objcdoc to dev/docs/doc/objcdoc
Expected file dev/docs/doc/objcdoc/objc/Classes/FlutterViewController.html not found

@szakarias
Copy link
Contributor Author

I believe the path should be dev/docs/doc/objcdoc/Classes/FlutterViewController.html without 'objc' before 'Classes' but I see you fixed that in your commit.

gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants