Making xcode version consistent across .ci.yaml. #109009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were multiple versions of xcode referenced in the .ci.yaml file, making it consistent to the expected 13f17a version. Bug: flutter#109008
jmagman
approved these changes
Aug 5, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Is version even being used? All the tests were already using 13f17a, I assume pulled from the xcode property.
Contributor
I don't think this dependency is officially being used (as you pointed out, most are using the xcode property still). However, I think either @drewroengoogle or @sealesj is working on pinning everything and migrating to the dependency format |
CaseyHillers
approved these changes
Aug 5, 2022
yusuf-goog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 5, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple versions of xcode referenced in the .ci.yaml
file, making it consistent to the expected 13f17a version.
Bug: #109008
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.