Skip to content

Remove android_sdk and open_jdk from some iOS-only tests #108994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 4, 2022
Merged

Remove android_sdk and open_jdk from some iOS-only tests #108994

auto-submit merged 1 commit into from
Aug 4, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 4, 2022

Remove android_sdk and open_jdk from iOS and macOS tests that do not need them. Will avoid #98532 when running these tests on arm machines.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Aug 4, 2022
@jmagman jmagman marked this pull request as ready for review August 4, 2022 21:27
@jmagman jmagman requested a review from keyonghan as a code owner August 4, 2022 21:27
keyonghan
keyonghan approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added team-infra Owned by Infrastructure team autosubmit Merge PR when tree becomes green via auto submit App labels Aug 4, 2022
@auto-submit auto-submit bot merged commit 25b3788 into flutter:master Aug 4, 2022
@jmagman jmagman deleted the remove-jdk branch August 4, 2022 21:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
25b3788 Remove android_sdk and open_jdk from some iOS-only tests (flu…
e726bc9 
…tter/flutter#108994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
25b3788 Remove android_sdk and open_jdk from some iOS-only tests (flu…
8b68b62 
…tter/flutter#108994)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@jmagman @camsim99
Remove android_sdk and open_jdk from some iOS-only tests (flutter#108994
d6fb9f7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @keyonghan