Skip to content

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Aug 4, 2022

Without these the mega gallery analyzer benchmark is failing for unclear reasons. Regular analysis has been passing fine without these...

Fixes #108982.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 4, 2022
@goderbauer goderbauer added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Aug 4, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 4, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 4, 2022

Validations Fail.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2022
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2022
@christopherfujino
Copy link
Contributor

Merging now with checks pending to green the tree as it passes Linux analyze and the test it fixes only runs post-submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter analyzer reports avoid_redundant_argument_values and causes tree closure

3 participants