Change ClipboardStatusNofifier parameter in buildToolbar to ValueLise… #108917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
chunhtai
force-pushed
the
issues/99360-cleanup
branch
from
bd66959 to
ccf2d46
Compare
justinmc
approved these changes
Aug 10, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM but I left a few comments with questions so I understand the context a bit better.
| @override | ||
| void removeListener(VoidCallback listener) { | ||
| super.removeListener(listener); | ||
| if (!_disposed && !hasListeners) { |
Contributor
There was a problem hiding this comment.
Why aren't these disposed checks needed anymore, was this fixed somewhere in the framework?
| List<TextSelectionPoint> endpoints, | ||
| TextSelectionDelegate delegate, | ||
| ClipboardStatusNotifier? clipboardStatus, | ||
| ValueListenable<ClipboardStatus>? clipboardStatus, |
Contributor
There was a problem hiding this comment.
Is the idea here just to simplify things since no methods from ClipboardStatusNotifier are needed here?
Contributor
There was a problem hiding this comment.
Nevermind the answer is yes. I answered my own question by reading the original PR #98951.
chunhtai
added
the
autosubmit
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
Aug 11, 2022
…alueLise… (flutter#108917)" This reverts commit 98ce4bf.
This was referenced Aug 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tnable
fixes #99360
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.