send the FLUTTER_HOST env var as analytics' app installer ID #10889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
Jun 21, 2017
| // Send the branch name as the "channel". | ||
| _analytics.setSessionValue('cd2', FlutterVersion.getBranchName(whitelistBranchName: true)); | ||
| // Record the host as the application installer ID - the context that flutter_tools is running in. | ||
| if (platform.environment.containsKey('FLUTTER_HOST')) { |
Contributor
There was a problem hiding this comment.
Where does FLUTTER_HOST come from?
Contributor
Author
There was a problem hiding this comment.
There's more context here: #8989, but IDEs set it when invoking flutter (specifically so the flutter tools can use it to categorize its analytics).
tvolkert
approved these changes
Jun 21, 2017
Contributor
|
So cool, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sethladd @tvolkert @xster